From: Tom Tromey <tom@tromey.com>
To: "Potharla, Rupesh via Gdb-patches" <gdb-patches@sourceware.org>
Cc: "George, Jini Susan" <JiniSusan.George@amd.com>,
"Parasuraman, Hariharan" <Hariharan.Parasuraman@amd.com>,
"Sharma, Alok Kumar" <AlokKumar.Sharma@amd.com>,
"Potharla, Rupesh" <Rupesh.Potharla@amd.com>
Subject: Re: GDB/Fortran: Support for Assumed Rank Zero.
Date: Mon, 18 Apr 2022 07:31:16 -0600 [thread overview]
Message-ID: <87tuaqy0uz.fsf@tromey.com> (raw)
In-Reply-To: <DM6PR12MB42193AD60807B3C11A208306E7F19@DM6PR12MB4219.namprd12.prod.outlook.com> (Rupesh via Gdb-patches Potharla's message of "Sat, 16 Apr 2022 18:29:46 +0000")
>>>>> Potharla, Rupesh via Gdb-patches <gdb-patches@sourceware.org> writes:
> Requesting to review the attached patch with suggested code changes.
> + type->main_type->target_type->main_type->dyn_prop_list =
> + type->main_type->dyn_prop_list;
In the gdb style, the '=' goes on the next line, and also the
continuation line is just indented 2 spaces.
thanks,
Tom
next prev parent reply other threads:[~2022-04-18 13:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:55 Potharla, Rupesh via Gdb-patches
2022-04-13 18:27 ` Kevin Buettner via Gdb-patches
2022-04-14 10:30 ` Potharla, Rupesh via Gdb-patches
2022-04-14 21:28 ` Kevin Buettner via Gdb-patches
2022-04-15 13:33 ` Potharla, Rupesh via Gdb-patches
2022-04-15 19:31 ` Kevin Buettner via Gdb-patches
2022-04-16 18:29 ` Potharla, Rupesh via Gdb-patches
2022-04-18 13:31 ` Tom Tromey [this message]
2022-04-18 15:25 ` Potharla, Rupesh via Gdb-patches
2022-04-20 15:22 ` Andrew Burgess via Gdb-patches
2022-04-20 19:08 ` Potharla, Rupesh via Gdb-patches
2022-04-22 14:38 ` Andrew Burgess via Gdb-patches
2022-04-25 6:33 ` Potharla, Rupesh via Gdb-patches
2022-04-25 8:47 ` Andrew Burgess via Gdb-patches
2022-04-18 15:33 ` Kevin Buettner via Gdb-patches
2022-04-19 17:30 ` Kevin Buettner via Gdb-patches
2022-04-20 0:29 ` Potharla, Rupesh via Gdb-patches
2022-04-20 6:32 ` Kempke, Nils-Christian via Gdb-patches
2022-04-20 15:38 ` Kevin Buettner via Gdb-patches
2022-04-20 15:29 ` Andrew Burgess via Gdb-patches
2022-04-20 19:20 ` Potharla, Rupesh via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuaqy0uz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=AlokKumar.Sharma@amd.com \
--cc=Hariharan.Parasuraman@amd.com \
--cc=JiniSusan.George@amd.com \
--cc=Rupesh.Potharla@amd.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox