From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yfXwMeKEXWKRAgAAWB0awg (envelope-from ) for ; Mon, 18 Apr 2022 11:33:54 -0400 Received: by simark.ca (Postfix, from userid 112) id BB6311F327; Mon, 18 Apr 2022 11:33:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 369911E150 for ; Mon, 18 Apr 2022 11:33:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C742A385800E for ; Mon, 18 Apr 2022 15:33:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C742A385800E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650296033; bh=L6FGKvMFR4VnS6djQ6h3v6Y6HAHmvtMtw0cspqqAWGE=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HQwBKlNRlwNgr5d74MAfj1LCR+uVvC7fFbbnTTwvVhVXhBHeAe8ZVAZDBd14hn7jf gYkyOLMD/Dmadou7as6EuLBGbxftdmt40U+gOt6ucBy3c9GKWNI3HGH9OX2CJNTTGq 3ogqKDhzyNQvlffSeZxJSGfCiNmTtYr88dZ2rdoQ= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4AA803858D28 for ; Mon, 18 Apr 2022 15:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AA803858D28 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-124-FwRyaCq-MNeEzGRePhSNrg-1; Mon, 18 Apr 2022 11:33:30 -0400 X-MC-Unique: FwRyaCq-MNeEzGRePhSNrg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86934866DF5; Mon, 18 Apr 2022 15:33:30 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0060E215CDCA; Mon, 18 Apr 2022 15:33:29 +0000 (UTC) Date: Mon, 18 Apr 2022 08:33:28 -0700 To: "Potharla, Rupesh" Subject: Re: GDB/Fortran: Support for Assumed Rank Zero. Message-ID: <20220418083328.5fb70540@f35-zws-1> In-Reply-To: References: <20220413112753.4c6f1128@f35-zws-1> <20220414142845.281b878d@f35-zws-1> <20220415123112.697ff872@f35-zws-1> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Sharma, Alok Kumar" , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Sat, 16 Apr 2022 18:29:46 +0000 "Potharla, Rupesh" wrote: > diff --git a/gdb/testsuite/gdb.fortran/assumedrank.exp b/gdb/testsuite/gdb.fortran/assumedrank.exp > index 69cd168125f..bd058e01e89 100644 > --- a/gdb/testsuite/gdb.fortran/assumedrank.exp > +++ b/gdb/testsuite/gdb.fortran/assumedrank.exp > @@ -58,6 +58,13 @@ while { $test_count < 500 } { > } > } > > + # XFAIL rank 0 for flang. > + if {$test_count == 1 && [test_compiler_info {clang-*}]} { > + setup_xfail "*-*-*" > + fail "compiler does not support rank 0" > + continue > + } > + > if ($found_final_breakpoint) { > break > } > Now that you're using setup_xfail, this should be moved into the loop above. Also, you should remove the fail and the continue. You'll want to use setup_xfail just before running the test for which you want to turn a possible FAIL into an XFAIL. I'm also (still) wondering how to run the testsuite to use flang instead of gfortran since it'd be nice to test to see if the setup_xfail actually works. I spent just enough time looking at it last week to convince myself that GDB's testing infrastructure currently lacks the mechanisms to do this. However, I could be wrong, so if someone knows how it's done, I'd like to learn about it... Kevin