From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] physname regression: Non-matching type false breakpoint
Date: Mon, 06 Jun 2011 09:22:00 -0000 [thread overview]
Message-ID: <201106061021.30546.pedro@codesourcery.com> (raw)
In-Reply-To: <20110605153419.GA14873@host1.jankratochvil.net>
On Sunday 05 June 2011 16:34:19, Jan Kratochvil wrote:
> + /* The strchr check is there if any types were specified verify the single
> + found found parameter types really match those specified by user in COPY.
> + */
I have trouble parsing this sentence. The "The strchr check is there"
part doesn't glue nicely with the other part to my ears. I suggest
dropping it. Is a comma or colon missing between specified/verify,
perhaps? Is double-"found" a typo? Hmm, looking at the code,
how about this alternative comment?
+ /* If we found a single field with that name, and we were not given
+ a specific overload instance in COPY, accept the field, if it's
+ really a method. */
+ if (i1 == 1 && strchr (copy, '(') == NULL)
--
Pedro Alves
next prev parent reply other threads:[~2011-06-06 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 15:34 Jan Kratochvil
2011-06-05 15:57 ` Mark Kettenis
2011-06-05 16:19 ` comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Jan Kratochvil
2011-06-05 16:23 ` Andreas Schwab
2011-06-05 16:35 ` Jan Kratochvil
2011-06-05 16:50 ` Alfred M. Szmidt
2011-06-05 16:57 ` Jan Kratochvil
2011-06-05 17:15 ` Alfred M. Szmidt
2011-06-05 17:24 ` Jan Kratochvil
2011-06-05 22:25 ` Alfred M. Szmidt
2011-06-05 17:49 ` Mark Kettenis
2011-06-06 9:22 ` Pedro Alves [this message]
2011-06-06 21:20 ` [patch] physname regression: Non-matching type false breakpoint Jan Kratochvil
2011-06-07 16:58 ` Pedro Alves
2011-07-01 20:29 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106061021.30546.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox