Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: schwab@linux-m68k.org, gdb-patches@sourceware.org
Subject: Re: comments formatting  [Re: [patch] physname regression: Non-matching type false breakpoint]
Date: Sun, 05 Jun 2011 17:49:00 -0000	[thread overview]
Message-ID: <201106051748.p55HmoqD008982@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110605163506.GA1273@host1.jankratochvil.net> (message from Jan	Kratochvil on Sun, 5 Jun 2011 18:35:06 +0200)

> Date: Sun, 5 Jun 2011 18:35:06 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Sun, 05 Jun 2011 18:23:40 +0200, Andreas Schwab wrote:
> > Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> > > I agree, this commonly happens, I do not know what is the right way to do with it.
> > 
> > M-q (c-fill-paragraph)
> 
> What does it do?  I use VIM.

See, there is your problem ;).

Seriosuly though, given that people use different tools some
reformatting of comments simply can't be avoided.  If I make changes
to a comment I'll make some effort to minimize the diff, but if the
changes are in the middle of the comment, or if the end-result simply
looks wrong I'll simply hit M-q and be done with it.  And */ on a line
of its own will almost certainly make me hit M-q.  Which is why I
brought this up.

In this case I'd simply move the last word of the previous line to the
next line to avoid the dangling */.

Cheers,

Mark


  parent reply	other threads:[~2011-06-05 17:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05 15:34 [patch] physname regression: Non-matching type false breakpoint Jan Kratochvil
2011-06-05 15:57 ` Mark Kettenis
2011-06-05 16:19   ` comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Jan Kratochvil
2011-06-05 16:23     ` Andreas Schwab
2011-06-05 16:35       ` Jan Kratochvil
2011-06-05 16:50         ` Alfred M. Szmidt
2011-06-05 16:57           ` Jan Kratochvil
2011-06-05 17:15             ` Alfred M. Szmidt
2011-06-05 17:24               ` Jan Kratochvil
2011-06-05 22:25                 ` Alfred M. Szmidt
2011-06-05 17:49         ` Mark Kettenis [this message]
2011-06-06  9:22 ` [patch] physname regression: Non-matching type false breakpoint Pedro Alves
2011-06-06 21:20   ` Jan Kratochvil
2011-06-07 16:58     ` Pedro Alves
2011-07-01 20:29       ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201106051748.p55HmoqD008982@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox