Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ams@gnu.org (Alfred M. Szmidt)
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: schwab@linux-m68k.org, mark.kettenis@xs4all.nl,
	gdb-patches@sourceware.org
Subject: Re: comments formatting  [Re: [patch] physname regression: Non-matching type false breakpoint]
Date: Sun, 05 Jun 2011 22:25:00 -0000	[thread overview]
Message-ID: <E1QTLkW-0002ER-Jq@fencepost.gnu.org> (raw)
In-Reply-To: <20110605172340.GA14424@host1.jankratochvil.net> (message from	Jan Kratochvil on Sun, 5 Jun 2011 19:23:40 +0200)

   >    OK (in VIM it is gq} or gqip ).  I use 79 columns instead of 70.
   >    So in the case of 70 columns what would be the right formatting of:
   > 
   >    /* The strchr check is there if any types were specified verify the single found found parameter types really match those specified by user in COPY.  */

   This is not a quote of my text, I wrote:
	/* The strchr check is there if any verify the single found found parameter foo types really match those specified by user in COPY.  */

It (c-fill-paragraph) will reformat it correctly, comment starting at
column 0:

/* The strchr check is there if any verify the single found found
   parameter foo types really match those specified by user in
   COPY.  */

Starting at column 8:

        /* The strchr check is there if any verify the single found
           found parameter foo types really match those specified by
           user in COPY.  */


This applies only to the C mode though, since it takes care to look at
how comments start and end; the normal text function, fill-paragraph,
does not do that and pretends that a closing comment signature is just
a normal word.  In which case it would format it like so (column 0):

/* The strchr check is there if any verify the single found found
   parameter foo types really match those specified by user in COPY.
   */

   > It would be the one I produced in the previous email:

   The text I provided was specially crafted to hit the same problem
   with 70 columns as I faced with the 79 columns and as I / others
   will face in the future.

   When the GNU Coding Standard does describe the comments formatting
   rules one has to unfortunately reverse engineer them from Emacs.

I think that the dangling */ on a single line is a cosmetic thing that
hasn't been thought of that much; it looks ugly to have it on a single
line.


  reply	other threads:[~2011-06-05 22:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05 15:34 [patch] physname regression: Non-matching type false breakpoint Jan Kratochvil
2011-06-05 15:57 ` Mark Kettenis
2011-06-05 16:19   ` comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Jan Kratochvil
2011-06-05 16:23     ` Andreas Schwab
2011-06-05 16:35       ` Jan Kratochvil
2011-06-05 16:50         ` Alfred M. Szmidt
2011-06-05 16:57           ` Jan Kratochvil
2011-06-05 17:15             ` Alfred M. Szmidt
2011-06-05 17:24               ` Jan Kratochvil
2011-06-05 22:25                 ` Alfred M. Szmidt [this message]
2011-06-05 17:49         ` Mark Kettenis
2011-06-06  9:22 ` [patch] physname regression: Non-matching type false breakpoint Pedro Alves
2011-06-06 21:20   ` Jan Kratochvil
2011-06-07 16:58     ` Pedro Alves
2011-07-01 20:29       ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1QTLkW-0002ER-Jq@fencepost.gnu.org \
    --to=ams@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox