Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: comments formatting  [Re: [patch] physname regression: Non-matching type false breakpoint]
Date: Sun, 05 Jun 2011 16:19:00 -0000	[thread overview]
Message-ID: <20110605161907.GA28751@host1.jankratochvil.net> (raw)
In-Reply-To: <201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl>

On Sun, 05 Jun 2011 17:57:31 +0200, Mark Kettenis wrote:
> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > +  /* The strchr check is there if any types were specified verify the single
> > +     found found parameter types really match those specified by user in COPY.
> > +     */
> 
> That lone */ looks weird.

I agree, this commonly happens, I do not know what is the right way to do with it.

 * exceeding 80 columns is forbidden: COPY.   */

 * Non-standard formatting of paragraph is not good - as the next modification
   will possibly reformat it a bit differently, creating false diffs confusing
   diff readers: by user in\n
   COPY.  */

 * I usually reword the sentence to fit the formatting better but TBH I do not
   find that a too much usefully spent time of my life.


Thanks,
Jan


  reply	other threads:[~2011-06-05 16:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05 15:34 [patch] physname regression: Non-matching type false breakpoint Jan Kratochvil
2011-06-05 15:57 ` Mark Kettenis
2011-06-05 16:19   ` Jan Kratochvil [this message]
2011-06-05 16:23     ` comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Andreas Schwab
2011-06-05 16:35       ` Jan Kratochvil
2011-06-05 16:50         ` Alfred M. Szmidt
2011-06-05 16:57           ` Jan Kratochvil
2011-06-05 17:15             ` Alfred M. Szmidt
2011-06-05 17:24               ` Jan Kratochvil
2011-06-05 22:25                 ` Alfred M. Szmidt
2011-06-05 17:49         ` Mark Kettenis
2011-06-06  9:22 ` [patch] physname regression: Non-matching type false breakpoint Pedro Alves
2011-06-06 21:20   ` Jan Kratochvil
2011-06-07 16:58     ` Pedro Alves
2011-07-01 20:29       ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110605161907.GA28751@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox