From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8066 invoked by alias); 5 Jun 2011 16:19:30 -0000 Received: (qmail 8058 invoked by uid 22791); 5 Jun 2011 16:19:30 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jun 2011 16:19:12 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p55GJBi3028559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 5 Jun 2011 12:19:11 -0400 Received: from host1.jankratochvil.net (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p55GJ92u009369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 5 Jun 2011 12:19:11 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p55GJ8Bj029943; Sun, 5 Jun 2011 18:19:08 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p55GJ7Bl029937; Sun, 5 Jun 2011 18:19:07 +0200 Date: Sun, 05 Jun 2011 16:19:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Message-ID: <20110605161907.GA28751@host1.jankratochvil.net> References: <20110605153419.GA14873@host1.jankratochvil.net> <201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00070.txt.bz2 On Sun, 05 Jun 2011 17:57:31 +0200, Mark Kettenis wrote: > > From: Jan Kratochvil > > + /* The strchr check is there if any types were specified verify the single > > + found found parameter types really match those specified by user in COPY. > > + */ > > That lone */ looks weird. I agree, this commonly happens, I do not know what is the right way to do with it. * exceeding 80 columns is forbidden: COPY. */ * Non-standard formatting of paragraph is not good - as the next modification will possibly reformat it a bit differently, creating false diffs confusing diff readers: by user in\n COPY. */ * I usually reword the sentence to fit the formatting better but TBH I do not find that a too much usefully spent time of my life. Thanks, Jan