[commit] Re: [patch] physname regression: Non-matching type false breakpoint

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Tue, 07 Jun 2011 18:58:27 +0200, Pedro Alves wrote:
> On Monday 06 June 2011 22:19:43, Jan Kratochvil wrote:
> > -  if (i1 == 1)
> > +  /* If we were given a specific overload instance in COPY defer the field
> > +     acceptance till the strcmp_iw verification below even if we found just
> > +     a single field with that name.  */
> 
> I suggest a comma after "COPY", and another after "below".

Done.

Checked in.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-07/msg00031.html

--- src/gdb/ChangeLog	2011/07/01 20:18:59	1.13153
+++ src/gdb/ChangeLog	2011/07/01 20:27:58	1.13154
@@ -1,5 +1,10 @@
 2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* linespec.c (find_method): Accept the function type automatically only
+	if it was specified with parameter types.
+
+2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	Stop on first linespec terminator instead of eating what we can.
 	* linespec.c (is_linespec_boundary): New function.
 	(name_end): Remove function.
--- src/gdb/linespec.c	2011/07/01 20:19:03	1.124
+++ src/gdb/linespec.c	2011/07/01 20:27:58	1.125
@@ -1697,7 +1697,10 @@
   i1 = find_methods (t, copy, SYMBOL_LANGUAGE (sym_class), sym_arr,
 		     file_symtab);
 
-  if (i1 == 1)
+  /* If we were given a specific overload instance in COPY, defer the field
+     acceptance till the strcmp_iw verification below, even if we found just
+     a single field with that name.  */
+  if (i1 == 1 && strchr (copy, '(') == NULL)
     {
       /* There is exactly one field with that name.  */
       sym = sym_arr[0];
--- src/gdb/testsuite/ChangeLog	2011/07/01 20:19:03	1.2776
+++ src/gdb/testsuite/ChangeLog	2011/07/01 20:27:59	1.2777
@@ -1,5 +1,10 @@
 2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* gdb.cp/paren-type.cc: New files.
+	* gdb.cp/paren-type.exp: New files.
+
+2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	Stop on first linespec terminator instead of eating what we can.
 	* gdb.cp/minsym-fallback-main.cc (main): Call also C::operator ().
 	* gdb.cp/minsym-fallback.cc (C::operator ()): Define.
--- src/gdb/testsuite/gdb.cp/paren-type.cc
+++ src/gdb/testsuite/gdb.cp/paren-type.cc	2011-07-01 20:28:47.786329000 +0000
@@ -0,0 +1,33 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2011 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+class C
+{
+public:
+  static void f (short x);
+};
+
+void
+C::f (short x)
+{
+}
+
+int
+main ()
+{
+  C::f(1);
+}
--- src/gdb/testsuite/gdb.cp/paren-type.exp
+++ src/gdb/testsuite/gdb.cp/paren-type.exp	2011-07-01 20:28:48.069315000 +0000
@@ -0,0 +1,26 @@
+# Copyright (C) 2011 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+set testfile paren-type
+if { [prepare_for_testing ${testfile}.exp ${testfile} ${testfile}.cc {c++ debug}] } {
+    return -1
+}
+
+gdb_test_no_output "set breakpoint pending off"
+
+gdb_test "break C::f(long)" {Function "C::f\(long\)" not defined\.}
+
+# Sanity check the breakpoints work for the correct type.
+gdb_test "break C::f(short)" "Breakpoint 1 at \[^\r\n\]*"