From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] physname regression: Non-matching type false breakpoint
Date: Sun, 05 Jun 2011 15:57:00 -0000 [thread overview]
Message-ID: <201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110605153419.GA14873@host1.jankratochvil.net> (message from Jan Kratochvil on Sun, 5 Jun 2011 17:34:19 +0200)
> Date: Sun, 5 Jun 2011 17:34:19 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> +++ b/gdb/linespec.c
> @@ -1732,7 +1732,10 @@ find_method (int funfirstline, struct linespec_result *canonical,
> i1 = find_methods (t, copy, SYMBOL_LANGUAGE (sym_class), sym_arr,
> file_symtab);
>
> - if (i1 == 1)
> + /* The strchr check is there if any types were specified verify the single
> + found found parameter types really match those specified by user in COPY.
> + */
That lone */ looks weird.
next prev parent reply other threads:[~2011-06-05 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 15:34 Jan Kratochvil
2011-06-05 15:57 ` Mark Kettenis [this message]
2011-06-05 16:19 ` comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint] Jan Kratochvil
2011-06-05 16:23 ` Andreas Schwab
2011-06-05 16:35 ` Jan Kratochvil
2011-06-05 16:50 ` Alfred M. Szmidt
2011-06-05 16:57 ` Jan Kratochvil
2011-06-05 17:15 ` Alfred M. Szmidt
2011-06-05 17:24 ` Jan Kratochvil
2011-06-05 22:25 ` Alfred M. Szmidt
2011-06-05 17:49 ` Mark Kettenis
2011-06-06 9:22 ` [patch] physname regression: Non-matching type false breakpoint Pedro Alves
2011-06-06 21:20 ` Jan Kratochvil
2011-06-07 16:58 ` Pedro Alves
2011-07-01 20:29 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox