From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3479 invoked by alias); 5 Jun 2011 15:57:54 -0000 Received: (qmail 3471 invoked by uid 22791); 5 Jun 2011 15:57:53 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jun 2011 15:57:38 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p55FvXjp013066; Sun, 5 Jun 2011 17:57:33 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p55FvVIu022894; Sun, 5 Jun 2011 17:57:31 +0200 (CEST) Date: Sun, 05 Jun 2011 15:57:00 -0000 Message-Id: <201106051557.p55FvVIu022894@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: jan.kratochvil@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <20110605153419.GA14873@host1.jankratochvil.net> (message from Jan Kratochvil on Sun, 5 Jun 2011 17:34:19 +0200) Subject: Re: [patch] physname regression: Non-matching type false breakpoint References: <20110605153419.GA14873@host1.jankratochvil.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00069.txt.bz2 > Date: Sun, 5 Jun 2011 17:34:19 +0200 > From: Jan Kratochvil > > +++ b/gdb/linespec.c > @@ -1732,7 +1732,10 @@ find_method (int funfirstline, struct linespec_result *canonical, > i1 = find_methods (t, copy, SYMBOL_LANGUAGE (sym_class), sym_arr, > file_symtab); > > - if (i1 == 1) > + /* The strchr check is there if any types were specified verify the single > + found found parameter types really match those specified by user in COPY. > + */ That lone */ looks weird.