From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29293 invoked by alias); 6 Jun 2011 09:22:04 -0000 Received: (qmail 29280 invoked by uid 22791); 6 Jun 2011 09:22:02 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 09:21:33 +0000 Received: (qmail 22942 invoked from network); 6 Jun 2011 09:21:32 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Jun 2011 09:21:32 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] physname regression: Non-matching type false breakpoint Date: Mon, 06 Jun 2011 09:22:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: Jan Kratochvil References: <20110605153419.GA14873@host1.jankratochvil.net> In-Reply-To: <20110605153419.GA14873@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201106061021.30546.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00085.txt.bz2 On Sunday 05 June 2011 16:34:19, Jan Kratochvil wrote: > + /* The strchr check is there if any types were specified verify the single > + found found parameter types really match those specified by user in COPY. > + */ I have trouble parsing this sentence. The "The strchr check is there" part doesn't glue nicely with the other part to my ears. I suggest dropping it. Is a comma or colon missing between specified/verify, perhaps? Is double-"found" a typo? Hmm, looking at the code, how about this alternative comment? + /* If we found a single field with that name, and we were not given + a specific overload instance in COPY, accept the field, if it's + really a method. */ + if (i1 == 1 && strchr (copy, '(') == NULL) -- Pedro Alves