Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Nick Roberts <nickrob@snap.net.nz>, gdb-patches@sourceware.org
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Mon, 25 Feb 2008 19:39:00 -0000	[thread overview]
Message-ID: <20080225192941.GA20216@adacore.com> (raw)
In-Reply-To: <200802251204.41848.vladimir@codesourcery.com>

Hi Volodya,

>     [gdb]
>     2008-02-15  Nick Roberts  <nickrob@snap.net.nz>
> 
>             * breakpoint.c (print_one_breakpoint_location): Revert Enb field
>             to old format.  Discard breakpoint address if shared library is
>             unloaded.
>             (breakpoint_1): Adjust formatting of table header accordingly.
> 
>     [gdb/testsuite]
>     2008-02-25  Vladimir Prus  <vladimir@codesourcery.com>
> 
>         * gdb.base/annota1.exp: Adjust for 'info break'
>         format changes.
>         * gdb.base/annota3.exp: Likewise.
>         * gdb.base/break.exp: Likewise.
>         * gdb.base/condbreak.exp: Likewise.
>         * gdb.base/pending.exp: Likewise.
>         * gdb.base/sepdebug.exp: Likewise.
>         * gdb.base/unload.exp: Likewise.
>         * gdb.cp/ovldbreak.exp: Likewise.
>         * gdb.mi/mi-pending.exp: Likewise.

Pfew, some of these lines were so long that it was really tough to
review some of them, but after stretching my terminal to some 300
characters wide, it became much easier :-).

Patch is approved. Many thanks to Nick and Vladimir for getting
this done.


-- 
Joel


  reply	other threads:[~2008-02-25 19:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080204214226.GF20922@adacore.com>
2008-02-04 21:55 ` Nick Roberts
2008-02-05  0:12   ` Joel Brobecker
2008-02-05  0:21     ` Joel Brobecker
2008-02-05  0:36       ` Nick Roberts
2008-02-05  0:54     ` Nick Roberts
2008-02-07  6:38       ` Joel Brobecker
2008-02-08  1:37         ` Nick Roberts
2008-02-08  6:44           ` Vladimir Prus
2008-02-08  7:37             ` Nick Roberts
2008-02-14 21:43               ` Joel Brobecker
2008-02-15  4:01                 ` Nick Roberts
2008-02-15  8:39                   ` Eli Zaretskii
2008-02-15  9:13                     ` Nick Roberts
2008-02-16 12:59                       ` Eli Zaretskii
2008-02-17  9:56                   ` Vladimir Prus
2008-02-17 19:53                     ` Nick Roberts
2008-02-19 19:02                   ` Joel Brobecker
2008-02-19 20:04                     ` Nick Roberts
2008-02-20 16:31                       ` Joel Brobecker
2008-02-20 19:21                         ` Nick Roberts
2008-02-20 20:27                           ` Vladimir Prus
2008-02-25 10:04                             ` Vladimir Prus
2008-02-25 19:39                               ` Joel Brobecker [this message]
2008-02-26 10:03                                 ` Vladimir Prus
2008-02-26 22:55                                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080225192941.GA20216@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox