Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Tue, 05 Feb 2008 00:36:00 -0000	[thread overview]
Message-ID: <18343.44916.257484.863207@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080205002116.GK21614@adacore.com>

 > And I forgot. You can also avoid some code duplication by changing:
 > 
 > Index: breakpoint.c
 > ===================================================================
 > --- breakpoint.c	(revision 146)
 > +++ breakpoint.c	(working copy)
 > @@ -3506,7 +3506,7 @@ print_one_breakpoint_location (struct br
 >  	if (addressprint)
 >  	  {
 >  	    annotate_field (4);
 > -	    if (b->loc == NULL)
 > +	    if (b->loc == NULL || loc->shlib_disabled)
 >  	      ui_out_field_string (uiout, "addr", "<PENDING>");
 >  	    else if (header_of_multiple)
 >  	      ui_out_field_string (uiout, "addr", "<MULTIPLE>");

That's what I had originally
(http://sourceware.org/ml/gdb-patches/2007-11/msg00262.html)

but Vladimir said:
(http://sourceware.org/ml/gdb-patches/2007-11/msg00266.html)

  I believe that in a case of breakpoint with multiple locations, where
  the first location is shlib_disabled, the updated code will print <PENDING>
  as address, not <MULTIPLE>.

  I think the right approach would be moving the check for loc->shlib_disabled
  later, like this:
  ...

so I did this as he was the author of the original patch.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-02-05  0:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080204214226.GF20922@adacore.com>
2008-02-04 21:55 ` Nick Roberts
2008-02-05  0:12   ` Joel Brobecker
2008-02-05  0:21     ` Joel Brobecker
2008-02-05  0:36       ` Nick Roberts [this message]
2008-02-05  0:54     ` Nick Roberts
2008-02-07  6:38       ` Joel Brobecker
2008-02-08  1:37         ` Nick Roberts
2008-02-08  6:44           ` Vladimir Prus
2008-02-08  7:37             ` Nick Roberts
2008-02-14 21:43               ` Joel Brobecker
2008-02-15  4:01                 ` Nick Roberts
2008-02-15  8:39                   ` Eli Zaretskii
2008-02-15  9:13                     ` Nick Roberts
2008-02-16 12:59                       ` Eli Zaretskii
2008-02-17  9:56                   ` Vladimir Prus
2008-02-17 19:53                     ` Nick Roberts
2008-02-19 19:02                   ` Joel Brobecker
2008-02-19 20:04                     ` Nick Roberts
2008-02-20 16:31                       ` Joel Brobecker
2008-02-20 19:21                         ` Nick Roberts
2008-02-20 20:27                           ` Vladimir Prus
2008-02-25 10:04                             ` Vladimir Prus
2008-02-25 19:39                               ` Joel Brobecker
2008-02-26 10:03                                 ` Vladimir Prus
2008-02-26 22:55                                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18343.44916.257484.863207@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox