Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: Joel Brobecker <brobecker@adacore.com>, 	gdb-patches@sourceware.org
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Fri, 08 Feb 2008 07:37:00 -0000	[thread overview]
Message-ID: <18348.1691.478013.310214@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200802080942.29622.ghost@cs.msu.su>

 > > Since it looks like Vladimir can't find the time to look at this
 > 
 > Huh? I don't think expecting a response within one business day
 > is quite reasonable.

I mean since last November when I first raised the issue.

 >...
 > >  > The idea is that you can't have header_of_multiple=1 and b->loc == NULL
 > >  > at the same time. So it's OK to move the check for header_of_multiple
 > >  > up.  And that avoids the code duplication.
 > > 
 > > I agree.
 > > 
 > > I can confirm that Gdb works as I would expect with these changes.
 >
 > Since you seem to have a patch relative to previous one, would you mind
 > sending a complete patch relative to CVS HEAD?

Joel's version is relative to CVS HEAD.  All I'm suggesting is that also
requires that the line

   ui_out_table_header (uiout, 4, ui_left, "enabled", "Enb");	/* 4 */

is changed back to

   ui_out_table_header (uiout, 3, ui_left, "enabled", "Enb");	/* 4 */

 > > 
 > > On a related note, breakpoint.c now has 7 columns:
 > > 
 > >   ui_out_table_header (uiout, 7, ui_left, "number", "Num");		/* 1 */
 > > 
 > > up from the previous 3:
 > > 
 > >   ui_out_table_header (uiout, 3, ui_left, "number", "Num");		/* 1 */
 > > 
 > > presumably for breakpoint numbers like 1.2 etc but it still seems to
 > > anticipate a very large number of breakpoints.
 > 
 > That's part of the original multiple location patch; I don't think
 > it's related in any way to what we're discussing now.

Granted, it's not central to the issue at hand but it's related in that it
also involves formatting of the header of the breakpoints table and was
made on the same day.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2008-02-08  7:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080204214226.GF20922@adacore.com>
2008-02-04 21:55 ` Nick Roberts
2008-02-05  0:12   ` Joel Brobecker
2008-02-05  0:21     ` Joel Brobecker
2008-02-05  0:36       ` Nick Roberts
2008-02-05  0:54     ` Nick Roberts
2008-02-07  6:38       ` Joel Brobecker
2008-02-08  1:37         ` Nick Roberts
2008-02-08  6:44           ` Vladimir Prus
2008-02-08  7:37             ` Nick Roberts [this message]
2008-02-14 21:43               ` Joel Brobecker
2008-02-15  4:01                 ` Nick Roberts
2008-02-15  8:39                   ` Eli Zaretskii
2008-02-15  9:13                     ` Nick Roberts
2008-02-16 12:59                       ` Eli Zaretskii
2008-02-17  9:56                   ` Vladimir Prus
2008-02-17 19:53                     ` Nick Roberts
2008-02-19 19:02                   ` Joel Brobecker
2008-02-19 20:04                     ` Nick Roberts
2008-02-20 16:31                       ` Joel Brobecker
2008-02-20 19:21                         ` Nick Roberts
2008-02-20 20:27                           ` Vladimir Prus
2008-02-25 10:04                             ` Vladimir Prus
2008-02-25 19:39                               ` Joel Brobecker
2008-02-26 10:03                                 ` Vladimir Prus
2008-02-26 22:55                                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18348.1691.478013.310214@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox