From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31215 invoked by alias); 8 Feb 2008 07:37:46 -0000 Received: (qmail 31206 invoked by uid 22791); 8 Feb 2008 07:37:45 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Feb 2008 07:37:15 +0000 Received: from kahikatea.snap.net.nz (181.31.255.123.static.snap.net.nz [123.255.31.181]) by viper.snap.net.nz (Postfix) with ESMTP id D04CC3DA0BD; Fri, 8 Feb 2008 20:37:12 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id B8CF08FC6D; Fri, 8 Feb 2008 20:37:00 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18348.1691.478013.310214@kahikatea.snap.net.nz> Date: Fri, 08 Feb 2008 07:37:00 -0000 To: Vladimir Prus Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded In-Reply-To: <200802080942.29622.ghost@cs.msu.su> References: <20080204214226.GF20922@adacore.com> <20080207063817.GA3907@adacore.com> <18347.45621.630420.453287@kahikatea.snap.net.nz> <200802080942.29622.ghost@cs.msu.su> X-Mailer: VM 7.19 under Emacs 22.1.90.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00148.txt.bz2 > > Since it looks like Vladimir can't find the time to look at this > > Huh? I don't think expecting a response within one business day > is quite reasonable. I mean since last November when I first raised the issue. >... > > > The idea is that you can't have header_of_multiple=1 and b->loc == NULL > > > at the same time. So it's OK to move the check for header_of_multiple > > > up. And that avoids the code duplication. > > > > I agree. > > > > I can confirm that Gdb works as I would expect with these changes. > > Since you seem to have a patch relative to previous one, would you mind > sending a complete patch relative to CVS HEAD? Joel's version is relative to CVS HEAD. All I'm suggesting is that also requires that the line ui_out_table_header (uiout, 4, ui_left, "enabled", "Enb"); /* 4 */ is changed back to ui_out_table_header (uiout, 3, ui_left, "enabled", "Enb"); /* 4 */ > > > > On a related note, breakpoint.c now has 7 columns: > > > > ui_out_table_header (uiout, 7, ui_left, "number", "Num"); /* 1 */ > > > > up from the previous 3: > > > > ui_out_table_header (uiout, 3, ui_left, "number", "Num"); /* 1 */ > > > > presumably for breakpoint numbers like 1.2 etc but it still seems to > > anticipate a very large number of breakpoints. > > That's part of the original multiple location patch; I don't think > it's related in any way to what we're discussing now. Granted, it's not central to the issue at hand but it's related in that it also involves formatting of the header of the breakpoints table and was made on the same day. -- Nick http://www.inet.net.nz/~nickrob