Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sourceware.org
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Wed, 20 Feb 2008 16:31:00 -0000	[thread overview]
Message-ID: <20080220163125.GA3669@adacore.com> (raw)
In-Reply-To: <18363.13851.966889.923773@kahikatea.snap.net.nz>

Nick,

> You might find it disappointing that I've not rerun the testsuite but
> I find it disappointing that I have had to submit complete patches for
> code, doumentation and testsuite to revert changes which I pointed out
> broke things for Emacs.

Here is my point of view. It's my personal opinion on it and others
may have a different view on this, but FWIW: IMO, the reason why
a change "broke" emacs is because the GUD mode in emacs made some
undocumented assumptions on the format of that ouput of one of
the CLI commands. I recognize the importance of staying compatible,
particularly in a case like this where it seems relatively easy
to achieve. But you have to understand that nowhere did we promise
that we would make the CLI output "compatible". But again, we'll
do our best.

I have been more than willing to work with you on this, by delaying
the release and reviewing your patches, but I think we'll save each
other a lot of suffering if you accept that you are now in charge
of fixing this issue without trying to determine whether it should
be you or someone else that should be doing this.

So how about you submit a complete patch, following the usual protocol
rather than an abbreviated one? I'll review it promptly, and we can
put this episode behind us. As I said before, I reviewed the breakpoint.c
patch and it looked fine, so it's just a matter of taking a look at
the testsuite failures and adjust the testsuite accordingly (if
justified).

-- 
Joel


  reply	other threads:[~2008-02-20 16:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080204214226.GF20922@adacore.com>
2008-02-04 21:55 ` Nick Roberts
2008-02-05  0:12   ` Joel Brobecker
2008-02-05  0:21     ` Joel Brobecker
2008-02-05  0:36       ` Nick Roberts
2008-02-05  0:54     ` Nick Roberts
2008-02-07  6:38       ` Joel Brobecker
2008-02-08  1:37         ` Nick Roberts
2008-02-08  6:44           ` Vladimir Prus
2008-02-08  7:37             ` Nick Roberts
2008-02-14 21:43               ` Joel Brobecker
2008-02-15  4:01                 ` Nick Roberts
2008-02-15  8:39                   ` Eli Zaretskii
2008-02-15  9:13                     ` Nick Roberts
2008-02-16 12:59                       ` Eli Zaretskii
2008-02-17  9:56                   ` Vladimir Prus
2008-02-17 19:53                     ` Nick Roberts
2008-02-19 19:02                   ` Joel Brobecker
2008-02-19 20:04                     ` Nick Roberts
2008-02-20 16:31                       ` Joel Brobecker [this message]
2008-02-20 19:21                         ` Nick Roberts
2008-02-20 20:27                           ` Vladimir Prus
2008-02-25 10:04                             ` Vladimir Prus
2008-02-25 19:39                               ` Joel Brobecker
2008-02-26 10:03                                 ` Vladimir Prus
2008-02-26 22:55                                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080220163125.GA3669@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox