Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded
Date: Mon, 04 Feb 2008 21:55:00 -0000	[thread overview]
Message-ID: <18343.35253.667689.989145@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20080204214226.GF20922@adacore.com>

 > As far as I could tell, the discussions pointed towards the idea
 > of removing the address and replacing it with "<PENDING>". Can we
 > expect to see a patch along these lines sometimes soon?

I think the patch below, based on my initial patch and Vladimir's subsequent
comment, will fix it.  No regressions.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** breakpoint.c	04 Feb 2008 09:10:59 +1300	1.301
--- breakpoint.c	04 Feb 2008 09:11:02 +1300	
*************** print_one_breakpoint_location (struct br
*** 3425,3434 ****
    /* 4 */
    annotate_field (3);
    if (part_of_multiple)
!     ui_out_field_string (uiout, "enabled", 
! 			 loc->shlib_disabled 
! 			 ? (loc->enabled ? "y(p)" : "n(p)")
! 			 : (loc->enabled ? "y" : "n"));
    else
      {
        int pending = (b->loc == NULL || b->loc->shlib_disabled);
--- 3425,3431 ----
    /* 4 */
    annotate_field (3);
    if (part_of_multiple)
!     ui_out_field_string (uiout, "enabled", loc->enabled ? "y" : "n");
    else
      {
        int pending = (b->loc == NULL || b->loc->shlib_disabled);
*************** print_one_breakpoint_location (struct br
*** 3556,3561 ****
--- 3553,3560 ----
  	      ui_out_field_string (uiout, "addr", "<PENDING>");
  	    else if (header_of_multiple)
  	      ui_out_field_string (uiout, "addr", "<MULTIPLE>");
+ 	    else if (loc->shlib_disabled)
+ 	      ui_out_field_string (uiout, "addr", "<PENDING>");
  	    else
  	      ui_out_field_core_addr (uiout, "addr", loc->address);
  	  }


       reply	other threads:[~2008-02-04 21:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080204214226.GF20922@adacore.com>
2008-02-04 21:55 ` Nick Roberts [this message]
2008-02-05  0:12   ` Joel Brobecker
2008-02-05  0:21     ` Joel Brobecker
2008-02-05  0:36       ` Nick Roberts
2008-02-05  0:54     ` Nick Roberts
2008-02-07  6:38       ` Joel Brobecker
2008-02-08  1:37         ` Nick Roberts
2008-02-08  6:44           ` Vladimir Prus
2008-02-08  7:37             ` Nick Roberts
2008-02-14 21:43               ` Joel Brobecker
2008-02-15  4:01                 ` Nick Roberts
2008-02-15  8:39                   ` Eli Zaretskii
2008-02-15  9:13                     ` Nick Roberts
2008-02-16 12:59                       ` Eli Zaretskii
2008-02-17  9:56                   ` Vladimir Prus
2008-02-17 19:53                     ` Nick Roberts
2008-02-19 19:02                   ` Joel Brobecker
2008-02-19 20:04                     ` Nick Roberts
2008-02-20 16:31                       ` Joel Brobecker
2008-02-20 19:21                         ` Nick Roberts
2008-02-20 20:27                           ` Vladimir Prus
2008-02-25 10:04                             ` Vladimir Prus
2008-02-25 19:39                               ` Joel Brobecker
2008-02-26 10:03                                 ` Vladimir Prus
2008-02-26 22:55                                   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18343.35253.667689.989145@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox