From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21212 invoked by alias); 25 Feb 2008 19:30:10 -0000 Received: (qmail 21202 invoked by uid 22791); 25 Feb 2008 19:30:09 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Feb 2008 19:29:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B96EC2AA1BE; Mon, 25 Feb 2008 14:29:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kpmrCCt1DXq5; Mon, 25 Feb 2008 14:29:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 778D32A9F92; Mon, 25 Feb 2008 14:29:43 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 79A2CE7ACB; Mon, 25 Feb 2008 11:29:41 -0800 (PST) Date: Mon, 25 Feb 2008 19:39:00 -0000 From: Joel Brobecker To: Vladimir Prus Cc: Nick Roberts , gdb-patches@sourceware.org Subject: Re: (gdb-6.8) Discard breakpoint address if shared library is unloaded Message-ID: <20080225192941.GA20216@adacore.com> References: <20080204214226.GF20922@adacore.com> <18364.32147.39758.99346@kahikatea.snap.net.nz> <200802202325.51341.ghost@cs.msu.su> <200802251204.41848.vladimir@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802251204.41848.vladimir@codesourcery.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00375.txt.bz2 Hi Volodya, > [gdb] > 2008-02-15 Nick Roberts > > * breakpoint.c (print_one_breakpoint_location): Revert Enb field > to old format. Discard breakpoint address if shared library is > unloaded. > (breakpoint_1): Adjust formatting of table header accordingly. > > [gdb/testsuite] > 2008-02-25 Vladimir Prus > > * gdb.base/annota1.exp: Adjust for 'info break' > format changes. > * gdb.base/annota3.exp: Likewise. > * gdb.base/break.exp: Likewise. > * gdb.base/condbreak.exp: Likewise. > * gdb.base/pending.exp: Likewise. > * gdb.base/sepdebug.exp: Likewise. > * gdb.base/unload.exp: Likewise. > * gdb.cp/ovldbreak.exp: Likewise. > * gdb.mi/mi-pending.exp: Likewise. Pfew, some of these lines were so long that it was really tough to review some of them, but after stretching my terminal to some 300 characters wide, it became much easier :-). Patch is approved. Many thanks to Nick and Vladimir for getting this done. -- Joel