[rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c

[rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi,

in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which was deleted a long time
ago. I guess the code inside the if #define/#endif is dead code. This patch removes it. I'm not sure how to 
test it :-)


ChangeLog:

	* gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
	(PC_LOAD_SEGMENT).

Is this ok to commit?

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff-PC_LOAD_SEGMENT --]
[-- Type: text/plain, Size: 746 bytes --]

diff -urN src/gdb/gdbtk/generic/gdbtk-stack.c dev/gdb/gdbtk/generic/gdbtk-stack.c
--- src/gdb/gdbtk/generic/gdbtk-stack.c	2007-05-23 05:30:04.000000000 +0200
+++ dev/gdb/gdbtk/generic/gdbtk-stack.c	2007-06-22 09:48:32.000000000 +0200
@@ -601,16 +601,6 @@
 			      DMGL_ANSI);
 #endif
       objv[0] = Tcl_NewStringObj (funname != NULL ? funname : "??", -1);
-#ifdef PC_LOAD_SEGMENT
-      /* If we couldn't print out function name but if can figure out what
-         load segment this pc value is from, at least print out some info
-         about its load segment. */
-      if (!funname)
-	{
-	  Tcl_AppendStringsToObj (objv[0], " from ", PC_LOAD_SEGMENT (fi->pc),
-				  (char *) NULL);
-	}
-#endif
 #ifdef PC_SOLIB
       if (!funname)
 	{

Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c

[Daniel Jacobowitz]

On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> Hi,
> 
> in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which 
> was deleted a long time
> ago. I guess the code inside the if #define/#endif is dead code. This patch 
> removes it. I'm not sure how to test it :-)
> 
> 
> ChangeLog:
> 
> 	* gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> 	(PC_LOAD_SEGMENT).
> 
> Is this ok to commit?

Two things:

- PC_LOAD_SEGMENT is in gdbint, too.  Could you remove it when you
have a chance?

- This patch is for Insight, so you should probably send it to the
Insight mailing list instead.

It looks fine to me though.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> > Hi,
> > 
> > in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which 
> > was deleted a long time
> > ago. I guess the code inside the if #define/#endif is dead code. This patch 
> > removes it. I'm not sure how to test it :-)
> > 
> > 
> > ChangeLog:
> > 
> > 	* gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> > 	(PC_LOAD_SEGMENT).
> > 
> > Is this ok to commit?
> 
> Two things:
> 
> - PC_LOAD_SEGMENT is in gdbint, too.  Could you remove it when you
> have a chance?
> 
> - This patch is for Insight, so you should probably send it to the
> Insight mailing list instead.

The patch was approved by Keith Seitz off-list, so I've checked it in.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com