Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
Date: Fri, 22 Jun 2007 07:53:00 -0000	[thread overview]
Message-ID: <467B7FB8.80100@de.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

Hi,

in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which was deleted a long time
ago. I guess the code inside the if #define/#endif is dead code. This patch removes it. I'm not sure how to 
test it :-)


ChangeLog:

	* gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
	(PC_LOAD_SEGMENT).

Is this ok to commit?

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff-PC_LOAD_SEGMENT --]
[-- Type: text/plain, Size: 746 bytes --]

diff -urN src/gdb/gdbtk/generic/gdbtk-stack.c dev/gdb/gdbtk/generic/gdbtk-stack.c
--- src/gdb/gdbtk/generic/gdbtk-stack.c	2007-05-23 05:30:04.000000000 +0200
+++ dev/gdb/gdbtk/generic/gdbtk-stack.c	2007-06-22 09:48:32.000000000 +0200
@@ -601,16 +601,6 @@
 			      DMGL_ANSI);
 #endif
       objv[0] = Tcl_NewStringObj (funname != NULL ? funname : "??", -1);
-#ifdef PC_LOAD_SEGMENT
-      /* If we couldn't print out function name but if can figure out what
-         load segment this pc value is from, at least print out some info
-         about its load segment. */
-      if (!funname)
-	{
-	  Tcl_AppendStringsToObj (objv[0], " from ", PC_LOAD_SEGMENT (fi->pc),
-				  (char *) NULL);
-	}
-#endif
 #ifdef PC_SOLIB
       if (!funname)
 	{

             reply	other threads:[~2007-06-22  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22  7:53 Markus Deuling [this message]
2007-07-01 22:33 ` Daniel Jacobowitz
2007-07-02 18:37   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467B7FB8.80100@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox