From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: deuling@de.ibm.com (Markus Deuling),
gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
Date: Mon, 02 Jul 2007 18:37:00 -0000 [thread overview]
Message-ID: <200707021837.l62IbhnY002353@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070701223248.GA337@caradoc.them.org> from "Daniel Jacobowitz" at Jul 01, 2007 06:32:48 PM
Daniel Jacobowitz wrote:
> On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> > Hi,
> >
> > in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which
> > was deleted a long time
> > ago. I guess the code inside the if #define/#endif is dead code. This patch
> > removes it. I'm not sure how to test it :-)
> >
> >
> > ChangeLog:
> >
> > * gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> > (PC_LOAD_SEGMENT).
> >
> > Is this ok to commit?
>
> Two things:
>
> - PC_LOAD_SEGMENT is in gdbint, too. Could you remove it when you
> have a chance?
>
> - This patch is for Insight, so you should probably send it to the
> Insight mailing list instead.
The patch was approved by Keith Seitz off-list, so I've checked it in.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2007-07-02 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 7:53 Markus Deuling
2007-07-01 22:33 ` Daniel Jacobowitz
2007-07-02 18:37 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707021837.l62IbhnY002353@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=deuling@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox