From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23477 invoked by alias); 2 Jul 2007 18:37:49 -0000 Received: (qmail 23469 invoked by uid 22791); 2 Jul 2007 18:37:48 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Jul 2007 18:37:46 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l62Ibi5l484606 for ; Mon, 2 Jul 2007 18:37:44 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l62Ibh5I1511426 for ; Mon, 2 Jul 2007 20:37:43 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l62IbhgX002356 for ; Mon, 2 Jul 2007 20:37:43 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l62IbhnY002353; Mon, 2 Jul 2007 20:37:43 +0200 Message-Id: <200707021837.l62IbhnY002353@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 2 Jul 2007 20:37:43 +0200 Subject: Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c To: drow@false.org (Daniel Jacobowitz) Date: Mon, 02 Jul 2007 18:37:00 -0000 From: "Ulrich Weigand" Cc: deuling@de.ibm.com (Markus Deuling), gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <20070701223248.GA337@caradoc.them.org> from "Daniel Jacobowitz" at Jul 01, 2007 06:32:48 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00037.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote: > > Hi, > > > > in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which > > was deleted a long time > > ago. I guess the code inside the if #define/#endif is dead code. This patch > > removes it. I'm not sure how to test it :-) > > > > > > ChangeLog: > > > > * gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code > > (PC_LOAD_SEGMENT). > > > > Is this ok to commit? > > Two things: > > - PC_LOAD_SEGMENT is in gdbint, too. Could you remove it when you > have a chance? > > - This patch is for Insight, so you should probably send it to the > Insight mailing list instead. The patch was approved by Keith Seitz off-list, so I've checked it in. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com