From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13256 invoked by alias); 22 Jun 2007 07:53:52 -0000 Received: (qmail 13248 invoked by uid 22791); 22 Jun 2007 07:53:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Jun 2007 07:53:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5M7rk2U153030 for ; Fri, 22 Jun 2007 07:53:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5M7rkos675846 for ; Fri, 22 Jun 2007 09:53:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5M7rkRF029284 for ; Fri, 22 Jun 2007 09:53:46 +0200 Received: from [9.152.248.39] (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5M7rjgZ029261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Jun 2007 09:53:46 +0200 Message-ID: <467B7FB8.80100@de.ibm.com> Date: Fri, 22 Jun 2007 07:53:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c Content-Type: multipart/mixed; boundary="------------080004080904080303090700" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00416.txt.bz2 This is a multi-part message in MIME format. --------------080004080904080303090700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 426 Hi, in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which was deleted a long time ago. I guess the code inside the if #define/#endif is dead code. This patch removes it. I'm not sure how to test it :-) ChangeLog: * gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code (PC_LOAD_SEGMENT). Is this ok to commit? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------080004080904080303090700 Content-Type: text/plain; name="diff-PC_LOAD_SEGMENT" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-PC_LOAD_SEGMENT" Content-length: 746 diff -urN src/gdb/gdbtk/generic/gdbtk-stack.c dev/gdb/gdbtk/generic/gdbtk-stack.c --- src/gdb/gdbtk/generic/gdbtk-stack.c 2007-05-23 05:30:04.000000000 +0200 +++ dev/gdb/gdbtk/generic/gdbtk-stack.c 2007-06-22 09:48:32.000000000 +0200 @@ -601,16 +601,6 @@ DMGL_ANSI); #endif objv[0] = Tcl_NewStringObj (funname != NULL ? funname : "??", -1); -#ifdef PC_LOAD_SEGMENT - /* If we couldn't print out function name but if can figure out what - load segment this pc value is from, at least print out some info - about its load segment. */ - if (!funname) - { - Tcl_AppendStringsToObj (objv[0], " from ", PC_LOAD_SEGMENT (fi->pc), - (char *) NULL); - } -#endif #ifdef PC_SOLIB if (!funname) { --------------080004080904080303090700--