From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49696-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28075 invoked by alias); 1 Jul 2007 22:33:21 -0000
Received: (qmail 28067 invoked by uid 22791); 1 Jul 2007 22:33:21 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 01 Jul 2007 22:33:19 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 77B8C982B8; 	Sun,  1 Jul 2007 22:33:18 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 58A5B98299; 	Sun,  1 Jul 2007 22:33:18 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.67) 	(envelope-from <drow@caradoc.them.org>) 	id 1I57yK-00005k-6V; Sun, 01 Jul 2007 18:32:48 -0400
Date: Sun, 01 Jul 2007 22:33:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, 	Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
Message-ID: <20070701223248.GA337@caradoc.them.org>
Mail-Followup-To: Markus Deuling <deuling@de.ibm.com>, 	GDB Patches <gdb-patches@sourceware.org>, 	Ulrich Weigand <uweigand@de.ibm.com>
References: <467B7FB8.80100@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <467B7FB8.80100@de.ibm.com>
User-Agent: Mutt/1.5.15 (2007-04-09)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-07/txt/msg00021.txt.bz2

On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> Hi,
> 
> in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which 
> was deleted a long time
> ago. I guess the code inside the if #define/#endif is dead code. This patch 
> removes it. I'm not sure how to test it :-)
> 
> 
> ChangeLog:
> 
> 	* gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> 	(PC_LOAD_SEGMENT).
> 
> Is this ok to commit?

Two things:

- PC_LOAD_SEGMENT is in gdbint, too.  Could you remove it when you
have a chance?

- This patch is for Insight, so you should probably send it to the
Insight mailing list instead.

It looks fine to me though.

-- 
Daniel Jacobowitz
CodeSourcery