[RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp

[RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

I noticed that this testcase is using gdb_suppress_entire_file, and
I remember being told that this function was evil. So I suggest the
following cleanup for this gdb.asm test:

2004-04-19  Joel Brobecker  <brobecker@gnat.com>

        * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.

OK to apply?

-- 
Joel

[-- Attachment #2: unsupported.diff --]
[-- Type: text/plain, Size: 668 bytes --]

Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.49
diff -u -p -r1.49 asm-source.exp
--- gdb.asm/asm-source.exp	31 Jan 2004 14:32:24 -0000	1.49
+++ gdb.asm/asm-source.exp	19 Apr 2004 17:24:56 -0000
@@ -115,7 +115,8 @@ switch -glob -- [istarget] {
 }
 
 if { "${asm-arch}" == "" } {
-    gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    unsupported "Assembly source test -- not implemented for this target."
+    return -1
 }
 
 # On NetBSD/ELF we need a special NetBSD-identifying note section.

Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp

[Daniel Jacobowitz]

On Mon, Apr 19, 2004 at 10:29:36AM -0700, Joel Brobecker wrote:
> I noticed that this testcase is using gdb_suppress_entire_file, and
> I remember being told that this function was evil. So I suggest the
> following cleanup for this gdb.asm test:
> 
> 2004-04-19  Joel Brobecker  <brobecker@gnat.com>
> 
>         * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.
> 
> OK to apply?

In general, I agree, but this particular file is a can of worms.
Andrew likes the extremely noisy failure, to encourage people to port
the test to new targets.  I'm not sure what I think about it; every
time I run into the issue I just do the port, so...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp

[Joel Brobecker]

> In general, I agree, but this particular file is a can of worms.
> Andrew likes the extremely noisy failure, to encourage people to port
> the test to new targets.  I'm not sure what I think about it; every
> time I run into the issue I just do the port, so...

OK, thanks for the feedback. Patch withdrawn for now. I just noticed that
the patch was incomplete in any case, since there were several other
instances of calls to that function...

-- 
Joel