From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32416-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 15658 invoked by alias); 19 Apr 2004 17:29:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15649 invoked from network); 19 Apr 2004 17:29:35 -0000
Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108)
  by sources.redhat.com with SMTP; 19 Apr 2004 17:29:35 -0000
Received: by takamaka.act-europe.fr (Postfix, from userid 507)
	id 1AD3D47D63; Mon, 19 Apr 2004 10:29:36 -0700 (PDT)
Date: Mon, 19 Apr 2004 17:29:00 -0000
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp
Message-ID: <20040419172936.GY22414@gnat.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="5vjQsMS/9MbKYGLq"
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-SW-Source: 2004-04/txt/msg00431.txt.bz2


--5vjQsMS/9MbKYGLq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-length: 326

I noticed that this testcase is using gdb_suppress_entire_file, and
I remember being told that this function was evil. So I suggest the
following cleanup for this gdb.asm test:

2004-04-19  Joel Brobecker  <brobecker@gnat.com>

        * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.

OK to apply?

-- 
Joel

--5vjQsMS/9MbKYGLq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="unsupported.diff"
Content-length: 668

Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.49
diff -u -p -r1.49 asm-source.exp
--- gdb.asm/asm-source.exp	31 Jan 2004 14:32:24 -0000	1.49
+++ gdb.asm/asm-source.exp	19 Apr 2004 17:24:56 -0000
@@ -115,7 +115,8 @@ switch -glob -- [istarget] {
 }
 
 if { "${asm-arch}" == "" } {
-    gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+    unsupported "Assembly source test -- not implemented for this target."
+    return -1
 }
 
 # On NetBSD/ELF we need a special NetBSD-identifying note section.

--5vjQsMS/9MbKYGLq--