From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp
Date: Mon, 19 Apr 2004 17:36:00 -0000 [thread overview]
Message-ID: <20040419173631.GA12719@nevyn.them.org> (raw)
In-Reply-To: <20040419172936.GY22414@gnat.com>
On Mon, Apr 19, 2004 at 10:29:36AM -0700, Joel Brobecker wrote:
> I noticed that this testcase is using gdb_suppress_entire_file, and
> I remember being told that this function was evil. So I suggest the
> following cleanup for this gdb.asm test:
>
> 2004-04-19 Joel Brobecker <brobecker@gnat.com>
>
> * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.
>
> OK to apply?
In general, I agree, but this particular file is a can of worms.
Andrew likes the extremely noisy failure, to encourage people to port
the test to new targets. I'm not sure what I think about it; every
time I run into the issue I just do the port, so...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-04-19 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 17:29 Joel Brobecker
2004-04-19 17:36 ` Daniel Jacobowitz [this message]
2004-04-19 17:43 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419173631.GA12719@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox