From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20828 invoked by alias); 19 Apr 2004 17:36:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20781 invoked from network); 19 Apr 2004 17:36:32 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 19 Apr 2004 17:36:32 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BFch5-0000zd-SV; Mon, 19 Apr 2004 13:36:32 -0400 Date: Mon, 19 Apr 2004 17:36:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp Message-ID: <20040419173631.GA12719@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20040419172936.GY22414@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040419172936.GY22414@gnat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00433.txt.bz2 On Mon, Apr 19, 2004 at 10:29:36AM -0700, Joel Brobecker wrote: > I noticed that this testcase is using gdb_suppress_entire_file, and > I remember being told that this function was evil. So I suggest the > following cleanup for this gdb.asm test: > > 2004-04-19 Joel Brobecker > > * gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file. > > OK to apply? In general, I agree, but this particular file is a can of worms. Andrew likes the extremely noisy failure, to encourage people to port the test to new targets. I'm not sure what I think about it; every time I run into the issue I just do the port, so... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer