From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/testsuite] get rid of gdb_suppress_entire_file in asm-source.exp
Date: Mon, 19 Apr 2004 17:29:00 -0000 [thread overview]
Message-ID: <20040419172936.GY22414@gnat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
I noticed that this testcase is using gdb_suppress_entire_file, and
I remember being told that this function was evil. So I suggest the
following cleanup for this gdb.asm test:
2004-04-19 Joel Brobecker <brobecker@gnat.com>
* gdb.asm/asm-source.exp: Remove use of gdb_suppress_entire_file.
OK to apply?
--
Joel
[-- Attachment #2: unsupported.diff --]
[-- Type: text/plain, Size: 668 bytes --]
Index: gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.49
diff -u -p -r1.49 asm-source.exp
--- gdb.asm/asm-source.exp 31 Jan 2004 14:32:24 -0000 1.49
+++ gdb.asm/asm-source.exp 19 Apr 2004 17:24:56 -0000
@@ -115,7 +115,8 @@ switch -glob -- [istarget] {
}
if { "${asm-arch}" == "" } {
- gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
+ unsupported "Assembly source test -- not implemented for this target."
+ return -1
}
# On NetBSD/ELF we need a special NetBSD-identifying note section.
next reply other threads:[~2004-04-19 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 17:29 Joel Brobecker [this message]
2004-04-19 17:36 ` Daniel Jacobowitz
2004-04-19 17:43 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419172936.GY22414@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox