From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sources.redhat.com
Subject: Re: PATCH: tests for MI commands
Date: Sun, 31 Jul 2005 23:32:00 -0000 [thread overview]
Message-ID: <17133.24533.145170.792002@farnswood.snap.net.nz> (raw)
In-Reply-To: <20050731221113.GC30901@nevyn.them.org>
> > I never intended to leave things broken. You have asked me to fix the
> > failures, and I will, but I'm not sure if that means submit further
> > patches to the mailing list or commit appropriate fixes. Based on Mark
> > Kettenis' e-mail,
>
> Submit patches, please.
OK.
> > I attach a simple fix for mi-var-child.exp. Does it work in your case? I
>
> > 2005-07-28 Nick Roberts <nickrob@snap.net.nz>
> >
> > * gdb.mi/mi-var-child.exp: Allow struct_declarations.character to be
> > uninitialized.
>
> First of all, it won't work. You added:
> value=\"0 '\\\\\\\\$decimal'\"
> which still has 0 in it :-)
Oops!
> Second, I get a value of 0 here, but the test still fails.
> func_ptr_struct and func_ptr_ptr aren't initialized either. Chasing
> uninitialized members is going to leave the tests script a bit of a
> mess.
>
> Initializing the whole structure proved to be a bit of a pain - these
> tests are ridiculously tricky to edit. But here it is. Tested on
> i686-pc-linux-gnu and committed. I hope this will be more useful if we
> add any additional value-related tests.
I find the number of backslashes needed confusing (because of the read syntax
for strings?). Your changes seem concise. I'll test these too.
Thanks again.
Nick
next prev parent reply other threads:[~2005-07-31 23:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 4:51 Nick Roberts
2005-07-24 21:19 ` Daniel Jacobowitz
2005-07-26 23:31 ` Nick Roberts
2005-07-27 0:27 ` Daniel Jacobowitz
2005-07-27 3:04 ` Nick Roberts
2005-07-27 3:55 ` Daniel Jacobowitz
2005-07-27 11:46 ` Nick Roberts
2005-07-27 12:50 ` Bob Rossi
2005-07-27 20:52 ` Nick Roberts
2005-07-27 21:49 ` Daniel Jacobowitz
2005-07-27 22:09 ` Nick Roberts
2005-07-27 21:03 ` Mark Kettenis
2005-07-27 22:23 ` Nick Roberts
2005-07-28 0:08 ` Paul Gilliam
2005-07-28 0:18 ` Stan Shebs
2005-07-28 0:21 ` Daniel Jacobowitz
2005-07-28 1:39 ` Nick Roberts
2005-07-31 22:11 ` Daniel Jacobowitz
2005-07-31 23:32 ` Nick Roberts [this message]
2005-08-01 1:55 ` Daniel Jacobowitz
2005-07-27 21:25 ` Mark Kettenis
2005-07-29 7:32 ` Nick Roberts
2005-07-31 21:25 ` Daniel Jacobowitz
2005-07-31 23:32 ` Nick Roberts
2005-08-01 1:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17133.24533.145170.792002@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox