Re: PATCH: tests for MI commands

[Daniel Jacobowitz <drow@false.org>]

On Wed, Jul 27, 2005 at 02:34:11PM +1200, Nick Roberts wrote:
> 
> > It's OK.  With the spacing/quoting fixes, go ahead and check it in.
> 
> Committed (with full log for each file).

You've broken many of the other tests using the source files you've
modified.  Please, run the entire GDB testsuite before committing
patches - as testsuites go it really doesn't take very long.

My test results are a wreck since I've recently started using GCC 4.0
to run tests - GDB does a Whole Lot Worse than it did for 3.x.  But it
looks like these failures are related to your change:

+FAIL: gdb.mi/mi-var-child.exp: listing of children, simple types: names, type and values, complex types: names and types
+FAIL: gdb.mi/mi-var-display.exp: get children local variable weird
+FAIL: gdb.mi/mi2-stack.exp: stack locals listing 0
+FAIL: gdb.mi/mi2-stack.exp: next in callee4 (timeout)
+FAIL: gdb.mi/mi2-stack.exp: stack locals listing 1
+FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations
+FAIL: gdb.mi/mi2-var-child.exp: get children of struct_declarations.long_array
+FAIL: gdb.mi/mi2-var-child.exp: get number of children of struct_declarations.long_array
+FAIL: gdb.mi/mi2-var-child.exp: get children of weird
+FAIL: gdb.mi/mi2-var-child.exp: get children of weird.long_array
+FAIL: gdb.mi/mi2-var-child.exp: get number of children of weird.long_array
+FAIL: gdb.mi/mi2-var-child.exp: delete var weird
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_a0_0 (stopped at wrong place)
+FAIL: gdb.mi/mi2-var-child.exp: delete var struct_declarations
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 1 (stopped at wrong place)
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 2 (stopped at wrong place)
+ERROR: Got interactive prompt.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->char_ptr (and 0.char_ptr) changed
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 3 (timeout)
+ERROR: Got interactive prompt.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->char_ptr (and 1.char_ptr) changed
+ERROR: Couldn't send -var-update * to GDB.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->char_ptr (and 2.char_ptr) chang ed
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 5 (timeout)
+ERROR: Couldn't send -var-update * to GDB.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->long_ptr (and 0.long_ptr) changed
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 6 (timeout)
+ERROR: Couldn't send -var-update * to GDB.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed
+FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout)
+ERROR: Couldn't send -var-update * to GDB.
+UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed
+FAIL: gdb.mi/mi2-var-display.exp: get children local variable weird

Please fix them - I think the easiest thing to do is to revert the
changes to the affected source files and switch those two modified
tests to using new source files.

As a side note, the trick to getting the CVS logs to come out right is
not just to use the same commit message for every file, but to commit
them together in a single invocation of cvs.  See the mailing list
archives for gdb-cvs to see the difference.

-- 
Daniel Jacobowitz
CodeSourcery, LLC