Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: tests for MI commands
Date: Sun, 31 Jul 2005 23:32:00 -0000	[thread overview]
Message-ID: <17133.23564.530245.592625@farnswood.snap.net.nz> (raw)
In-Reply-To: <20050731212522.GB30901@nevyn.them.org>

 > > I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to
 > > mi2-stack.exp and mi2-var-child.exp.  Creating new files mi-var-cmd.c,
 > > mi-basics.c etc seems more complicated.  Is this an acceptable short term
 > > solution?
 > 
 > It's not complicated at all.  Please see the attached patch, which I've
 > checked in.  It would be even simpler than this if folks had used
 > ${srcfile} to begin with.

Well now some mi-*.exp files e.g mi-var-block.exp use var-cmd.c while
others, namely mi-var-child.exp, use mi-var-child.c.  Clearly, though if
you do the work its simpler (for me!).

 > Tested on i686-pc-linux-gnu, where it resolves 18 FAILs and assorted
 > ERRORs.

Thanks.  I'll test them on my other machine, but I'm sure they will work.  I
guess the idea is that mi2-*.exp tests shouldn't change although I'm still not
convinced that they are useful - perhaps we can discuss that later.

In future, I'll run the whole testsuite before submitting patches, to save you
and others hassle.

Nick


  reply	other threads:[~2005-07-31 23:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-20  4:51 Nick Roberts
2005-07-24 21:19 ` Daniel Jacobowitz
2005-07-26 23:31   ` Nick Roberts
2005-07-27  0:27     ` Daniel Jacobowitz
2005-07-27  3:04       ` Nick Roberts
2005-07-27  3:55         ` Daniel Jacobowitz
2005-07-27 11:46           ` Nick Roberts
2005-07-27 12:50             ` Bob Rossi
2005-07-27 20:52               ` Nick Roberts
2005-07-27 21:49                 ` Daniel Jacobowitz
2005-07-27 22:09                   ` Nick Roberts
2005-07-27 21:03             ` Mark Kettenis
2005-07-27 22:23               ` Nick Roberts
2005-07-28  0:08                 ` Paul Gilliam
2005-07-28  0:18                 ` Stan Shebs
2005-07-28  0:21                 ` Daniel Jacobowitz
2005-07-28  1:39                   ` Nick Roberts
2005-07-31 22:11                     ` Daniel Jacobowitz
2005-07-31 23:32                       ` Nick Roberts
2005-08-01  1:55                         ` Daniel Jacobowitz
2005-07-27 21:25             ` Mark Kettenis
2005-07-29  7:32           ` Nick Roberts
2005-07-31 21:25             ` Daniel Jacobowitz
2005-07-31 23:32               ` Nick Roberts [this message]
2005-08-01  1:57                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17133.23564.530245.592625@farnswood.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox