From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10093 invoked by alias); 31 Jul 2005 23:32:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10079 invoked by uid 22791); 31 Jul 2005 23:32:08 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 31 Jul 2005 23:32:08 +0000 Received: from farnswood.snap.net.nz (p200-tnt1.snap.net.nz [202.124.110.200]) by viper.snap.net.nz (Postfix) with ESMTP id 1691B5F5E7E; Mon, 1 Aug 2005 11:32:05 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 5845162A99; Mon, 1 Aug 2005 00:17:33 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17133.23564.530245.592625@farnswood.snap.net.nz> Date: Sun, 31 Jul 2005 23:32:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands In-Reply-To: <20050731212522.GB30901@nevyn.them.org> References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> <17129.56052.792623.200657@farnswood.snap.net.nz> <20050731212522.GB30901@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00244.txt.bz2 > > I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to > > mi2-stack.exp and mi2-var-child.exp. Creating new files mi-var-cmd.c, > > mi-basics.c etc seems more complicated. Is this an acceptable short term > > solution? > > It's not complicated at all. Please see the attached patch, which I've > checked in. It would be even simpler than this if folks had used > ${srcfile} to begin with. Well now some mi-*.exp files e.g mi-var-block.exp use var-cmd.c while others, namely mi-var-child.exp, use mi-var-child.c. Clearly, though if you do the work its simpler (for me!). > Tested on i686-pc-linux-gnu, where it resolves 18 FAILs and assorted > ERRORs. Thanks. I'll test them on my other machine, but I'm sure they will work. I guess the idea is that mi2-*.exp tests shouldn't change although I'm still not convinced that they are useful - perhaps we can discuss that later. In future, I'll run the whole testsuite before submitting patches, to save you and others hassle. Nick