Re: PATCH: tests for MI commands

[Daniel Jacobowitz <drow@false.org>]

On Wed, Jul 20, 2005 at 04:51:03PM +1200, Nick Roberts wrote:
> 
> This patch provides tests for the recent changes to -var-update and
> -var-list-children.  I have also revised the test for stack-list-locals
> so that it properly tests the --simple-values option.
> 
> There is no test for "-var-update --simple-values" as I could not get it
> to behave differently for "-var-update --all-values".  I think this is
> because the changelist only consists of simple types; if it is complex
> its `value' is deemed not have changed.

Thanks.  The tests themselves look roughly fine, but:

> 	* gdb.mi/mi-var-child.exp: Adapt tests for extra elements and use
> 	them for tests for "-var-update --no-values" and
> 	"-var-update --all-values".  
> 	Add test for "-var-list-children --simple-values.

Missing quote mark.

> *************** do_children_tests (void)
> *** 227,232 ****
> --- 227,234 ----
>     struct_declarations.long_array[9] = 1234;
>   
>     weird->func_ptr = nothing;
> +   struct_declarations.long_array[10] = 3456;
> +   struct_declarations.long_array[11] = 5678;
>   
>     /* Struct/pointer/array tests */
>     a0 = '0';
> 

You had a bunch of changes that only were needed because you added
initializations between weird->func_ptr = nothing and a0 = '0'; why not
put them above it, with the others?  There might be some problem with
that I haven't seen...

> ! # Step over "weird->func_ptr = nothing;"
> ! set line_dct_a0_0 [gdb_get_line_number "a0 = '0';"]
>   mi_step_to do_children_tests {} {.*var-cmd.c} \
> !     $line_dct_a0_0 "step \$line_dct_a0_0"

> --- 833,842 ----

> ! # Step over weird->func_ptr = nothing;
>   mi_step_to do_children_tests {} {.*var-cmd.c} \
> !     [expr $line_dct_nothing + 1] "step \$line_dct_nothing + 1"

Please don't do math on line numbers; gdb_get_line_number helps make
test cases more robust against changes in the test source.

> + # Step overstruct_declarations.long_array[10] = 3456;

> +  "update  all vars struct_declarations.long_array.10 changed, don't print values."

Missing space; extra space.

-- 
Daniel Jacobowitz
CodeSourcery, LLC