From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: tests for MI commands
Date: Fri, 29 Jul 2005 07:32:00 -0000 [thread overview]
Message-ID: <17129.56052.792623.200657@farnswood.snap.net.nz> (raw)
In-Reply-To: <20050727035503.GA30670@nevyn.them.org>
Daniel Jacobowitz writes:
> You've broken many of the other tests using the source files you've
> modified. Please, run the entire GDB testsuite before committing
> patches - as testsuites go it really doesn't take very long.
...
> +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed
> +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout)
> +ERROR: Couldn't send -var-update * to GDB.
> +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed
>
> Please fix them - I think the easiest thing to do is to revert the
> changes to the affected source files and switch those two modified
> tests to using new source files.
I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to
mi2-stack.exp and mi2-var-child.exp. Creating new files mi-var-cmd.c,
mi-basics.c etc seems more complicated. Is this an acceptable short term
solution?
Nick
next prev parent reply other threads:[~2005-07-29 7:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 4:51 Nick Roberts
2005-07-24 21:19 ` Daniel Jacobowitz
2005-07-26 23:31 ` Nick Roberts
2005-07-27 0:27 ` Daniel Jacobowitz
2005-07-27 3:04 ` Nick Roberts
2005-07-27 3:55 ` Daniel Jacobowitz
2005-07-27 11:46 ` Nick Roberts
2005-07-27 12:50 ` Bob Rossi
2005-07-27 20:52 ` Nick Roberts
2005-07-27 21:49 ` Daniel Jacobowitz
2005-07-27 22:09 ` Nick Roberts
2005-07-27 21:03 ` Mark Kettenis
2005-07-27 22:23 ` Nick Roberts
2005-07-28 0:08 ` Paul Gilliam
2005-07-28 0:18 ` Stan Shebs
2005-07-28 0:21 ` Daniel Jacobowitz
2005-07-28 1:39 ` Nick Roberts
2005-07-31 22:11 ` Daniel Jacobowitz
2005-07-31 23:32 ` Nick Roberts
2005-08-01 1:55 ` Daniel Jacobowitz
2005-07-27 21:25 ` Mark Kettenis
2005-07-29 7:32 ` Nick Roberts [this message]
2005-07-31 21:25 ` Daniel Jacobowitz
2005-07-31 23:32 ` Nick Roberts
2005-08-01 1:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17129.56052.792623.200657@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox