From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31302 invoked by alias); 29 Jul 2005 07:32:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29713 invoked by uid 22791); 29 Jul 2005 07:28:52 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 29 Jul 2005 07:28:52 +0000 Received: from farnswood.snap.net.nz (p209-tnt1.snap.net.nz [202.124.110.209]) by viper.snap.net.nz (Postfix) with ESMTP id C090B5F588B; Fri, 29 Jul 2005 19:28:48 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 9B0FC62A99; Fri, 29 Jul 2005 08:29:57 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17129.56052.792623.200657@farnswood.snap.net.nz> Date: Fri, 29 Jul 2005 07:32:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands In-Reply-To: <20050727035503.GA30670@nevyn.them.org> References: <17117.55351.716393.763492@farnswood.snap.net.nz> <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00224.txt.bz2 Daniel Jacobowitz writes: > You've broken many of the other tests using the source files you've > modified. Please, run the entire GDB testsuite before committing > patches - as testsuites go it really doesn't take very long. ... > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->long_ptr (and 1.long_ptr) changed > +FAIL: gdb.mi/mi2-var-child.exp: step $line_dct_snp0 + 7 (timeout) > +ERROR: Couldn't send -var-update * to GDB. > +UNRESOLVED: gdb.mi/mi2-var-child.exp: update all vars psnp->next->next->long_ptr (and 2.long_ptr) changed > > Please fix them - I think the easiest thing to do is to revert the > changes to the affected source files and switch those two modified > tests to using new source files. I would rather copy my changes to mi-stack.exp and mi-var-child.exp over to mi2-stack.exp and mi2-var-child.exp. Creating new files mi-var-cmd.c, mi-basics.c etc seems more complicated. Is this an acceptable short term solution? Nick