From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10103 invoked by alias); 31 Jul 2005 23:32:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10069 invoked by uid 22791); 31 Jul 2005 23:32:07 -0000 Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 31 Jul 2005 23:32:07 +0000 Received: from farnswood.snap.net.nz (p200-tnt1.snap.net.nz [202.124.110.200]) by viper.snap.net.nz (Postfix) with ESMTP id CDF175F5E5F; Mon, 1 Aug 2005 11:32:02 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id E47AB62A9B; Mon, 1 Aug 2005 00:33:41 +0100 (BST) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17133.24533.145170.792002@farnswood.snap.net.nz> Date: Sun, 31 Jul 2005 23:32:00 -0000 To: Daniel Jacobowitz Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: PATCH: tests for MI commands In-Reply-To: <20050731221113.GC30901@nevyn.them.org> References: <20050724211946.GB798@nevyn.them.org> <17126.51233.887175.402254@farnswood.snap.net.nz> <20050727002721.GA27261@nevyn.them.org> <17126.62115.642102.742744@farnswood.snap.net.nz> <20050727035503.GA30670@nevyn.them.org> <17127.29797.456624.592127@farnswood.snap.net.nz> <200507272103.j6RL3HYf022581@elgar.sibelius.xs4all.nl> <17128.2540.73355.406922@farnswood.snap.net.nz> <20050728002057.GA25134@nevyn.them.org> <17128.14238.713213.954375@farnswood.snap.net.nz> <20050731221113.GC30901@nevyn.them.org> X-SW-Source: 2005-07/txt/msg00245.txt.bz2 > > I never intended to leave things broken. You have asked me to fix the > > failures, and I will, but I'm not sure if that means submit further > > patches to the mailing list or commit appropriate fixes. Based on Mark > > Kettenis' e-mail, > > Submit patches, please. OK. > > I attach a simple fix for mi-var-child.exp. Does it work in your case? I > > > 2005-07-28 Nick Roberts > > > > * gdb.mi/mi-var-child.exp: Allow struct_declarations.character to be > > uninitialized. > > First of all, it won't work. You added: > value=\"0 '\\\\\\\\$decimal'\" > which still has 0 in it :-) Oops! > Second, I get a value of 0 here, but the test still fails. > func_ptr_struct and func_ptr_ptr aren't initialized either. Chasing > uninitialized members is going to leave the tests script a bit of a > mess. > > Initializing the whole structure proved to be a bit of a pain - these > tests are ridiculously tricky to edit. But here it is. Tested on > i686-pc-linux-gnu and committed. I hope this will be more useful if we > add any additional value-related tests. I find the number of backslashes needed confusing (because of the read syntax for strings?). Your changes seem concise. I'll test these too. Thanks again. Nick