Re: [PATCH: gdb/mi + doco] -var-update

[Nick Roberts <nickrob@snap.net.nz>]

 > I have some spare time waiting for my patches to get reviewed, so I
 > figure'd I'd look at yours. If you care, I have just a few comments.

Sorry, Bob. I read this too quickly the first time and (stupidly) thought
that you had forgot to include the comments.

 > > + const char novalues[] = "\"--no-values\"";
 > > + const char withvalues[] = "\"--with-values\"";
 > > + const char simplevalues[] = "\"--simple-values\"";
 > > + const char allvalues[] = "\"--all-values\"";
 >
 > These could be made static.

Not really. I use them in my patch for mi-cmd-stack.c which I included in my
earlier submission (Sun, 27 Feb 2005 14:18:11 +1300) but left out on (Mar 19)
as it was unchanged.

 ...
 > > !       if (strcmp (argv[0], "0") == 0
 > > ! 	  || strcmp (argv[0], "--no-values") == 0)
 > > ! 	print_values = PRINT_NO_VALUES;
 > > !       else if (strcmp (argv[0], "1") == 0
 > > ! 	       || strcmp (argv[0], "--with-values") == 0)
 > 
 > instead of using "--no-values" and "--with-values" you could use the
 > variable "novalues" and "withvalues".

Yes. That would make sense.

 > > !   if (argc == 2)
 > > !     {
 > > !       if (strcmp (argv[0], "0") == 0
 > > ! 	  || strcmp (argv[0], "--no-values") == 0)
 > > ! 	print_values = PRINT_NO_VALUES;
 > > !       else if (strcmp (argv[0], "1") == 0
 > > ! 	       || strcmp (argv[0], "--with-values") == 0)
 > 
 > same as above with the --no-values and --with-values

Yes.

I will send the revised source (all files apart from doco which Eli has
already approved) to Daniel and cc gdb-patches.

Nick