Re: [PATCH: gdb/mi + doco] -var-update

[Daniel Jacobowitz <drow@false.org>]

On Mon, May 02, 2005 at 02:06:57PM +1200, Nick Roberts wrote:
>  > I have some spare time waiting for my patches to get reviewed, so I
>  > figure'd I'd look at yours. If you care, I have just a few comments.
> 
> Sorry, Bob. I read this too quickly the first time and (stupidly) thought
> that you had forgot to include the comments.
> 
>  > > + const char novalues[] = "\"--no-values\"";
>  > > + const char withvalues[] = "\"--with-values\"";
>  > > + const char simplevalues[] = "\"--simple-values\"";
>  > > + const char allvalues[] = "\"--all-values\"";
>  >
>  > These could be made static.
> 
> Not really. I use them in my patch for mi-cmd-stack.c which I included in my
> earlier submission (Sun, 27 Feb 2005 14:18:11 +1300) but left out on (Mar 19)
> as it was unchanged.

If you want these to be global variables, you need to give them better
names.  Also, the GDB coding style means that multiple words
get_underscores_for_separation.

>  ...
>  > > !       if (strcmp (argv[0], "0") == 0
>  > > ! 	  || strcmp (argv[0], "--no-values") == 0)
>  > > ! 	print_values = PRINT_NO_VALUES;
>  > > !       else if (strcmp (argv[0], "1") == 0
>  > > ! 	       || strcmp (argv[0], "--with-values") == 0)
>  > 
>  > instead of using "--no-values" and "--with-values" you could use the
>  > variable "novalues" and "withvalues".
> 
> Yes. That would make sense.

You'll need to strip the extra quote marks off those variables then -
which seems more natural anyway.

> I will send the revised source (all files apart from doco which Eli has
> already approved) to Daniel and cc gdb-patches.

Please include the documentation with the patch anyway; a complete
patch lets reviewers see the whole picture more easily.

-- 
Daniel Jacobowitz
CodeSourcery, LLC