From: "Eli Zaretskii" <eliz@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH: gdb/mi + doco] -var-update
Date: Mon, 21 Feb 2005 07:17:00 -0000 [thread overview]
Message-ID: <01c517d0$Blat.v2.4$09a26040@zahav.net.il> (raw)
In-Reply-To: <16921.18627.457594.938060@farnswood.snap.net.nz> (message from Nick Roberts on Mon, 21 Feb 2005 15:34:43 +1300)
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Mon, 21 Feb 2005 15:34:43 +1300
> Cc: gdb-patches@sources.redhat.com
>
> > If other messages are marked up with _(), then this is okay. But I
> > still think the const char [] strings should be defined once and used
> > elsewhere in this function.
>
> OK but this only makes sense if it is done consistently. So I offer to
> do it for all of the MI error messages.
It should be done for all messages, yes; but I'd like at least to have
the new messages follow that principle.
> > > I've used "--all-values" because, in the case of -var-list-children there
> > > is a third possibility: "--simple-values" and, to me, it seems simpler to
> > > have only three values for print_values (mi-cmds.h):
> > >
> > > enum print_values {
> > > PRINT_NO_VALUES,
> > > PRINT_ALL_VALUES,
> > > PRINT_SIMPLE_VALUES
> > > };
> >
> > I see the reason, but I think it is not important enough to use
> > "--all-values". Anyway, the switch text does not need to be similar
> > to the enum name, even if you use PRINT_ALL_VALUES in the enum.
>
> OK. But again this only makes sense if I change -var-list-children too.
What change did you have in mind?
next prev parent reply other threads:[~2005-02-21 4:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-20 2:06 Nick Roberts
2005-02-20 5:02 ` Eli Zaretskii
2005-02-20 5:51 ` Nick Roberts
2005-02-20 15:31 ` Eli Zaretskii
2005-02-21 4:33 ` Nick Roberts
2005-02-21 7:17 ` Eli Zaretskii [this message]
2005-02-22 9:23 ` Nick Roberts
2005-02-22 9:34 ` Eli Zaretskii
2005-02-27 5:03 ` Nick Roberts
2005-02-27 16:53 ` Eli Zaretskii
2005-02-27 16:56 ` Nick Roberts
2005-02-28 12:27 ` Eli Zaretskii
2005-03-19 3:55 ` Nick Roberts
2005-04-01 1:51 ` Bob Rossi
2005-04-01 11:01 ` Nick Roberts
2005-05-02 2:06 ` Nick Roberts
2005-05-02 4:05 ` Daniel Jacobowitz
2005-05-02 7:24 ` Nick Roberts
2005-06-17 3:43 ` Daniel Jacobowitz
2005-06-17 10:09 ` Eli Zaretskii
2005-06-17 14:04 ` Daniel Jacobowitz
2005-06-18 8:53 ` Eli Zaretskii
2005-07-03 19:56 ` Daniel Jacobowitz
2005-07-04 3:07 ` Nick Roberts
2005-07-04 3:51 ` Daniel Jacobowitz
2005-07-04 4:55 ` Eli Zaretskii
2005-07-04 5:02 ` Daniel Jacobowitz
2005-07-04 10:17 ` Nick Roberts
2005-07-06 10:00 ` Nick Roberts
2005-07-15 1:44 ` Daniel Jacobowitz
2005-07-15 3:59 ` Nick Roberts
2005-07-15 4:16 ` Daniel Jacobowitz
2005-07-15 15:11 ` Nick Roberts
2005-07-15 15:28 ` Daniel Jacobowitz
2005-07-15 22:37 ` Nick Roberts
2005-07-04 21:15 ` Nick Roberts
2005-07-04 22:24 ` Eli Zaretskii
2005-07-05 3:25 ` Nick Roberts
2005-07-05 19:37 ` Eli Zaretskii
2005-07-15 9:42 ` Nick Roberts
2005-06-17 11:42 ` Nick Roberts
2005-06-17 14:06 ` Daniel Jacobowitz
2005-06-17 23:12 ` Nick Roberts
2005-02-21 2:36 ` Andrew Cagney
2005-02-21 3:28 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c517d0$Blat.v2.4$09a26040@zahav.net.il' \
--to=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox