From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21713 invoked by alias); 21 Feb 2005 04:44:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21674 invoked from network); 21 Feb 2005 04:44:48 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 21 Feb 2005 04:44:48 -0000 Received: from zaretski (IGLD-83-130-200-21.inter.net.il [83.130.200.21]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AOV22250 (AUTH halo1); Mon, 21 Feb 2005 06:44:39 +0200 (IST) Date: Mon, 21 Feb 2005 07:17:00 -0000 From: "Eli Zaretskii" To: Nick Roberts Message-ID: <01c517d0$Blat.v2.4$09a26040@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <16921.18627.457594.938060@farnswood.snap.net.nz> (message from Nick Roberts on Mon, 21 Feb 2005 15:34:43 +1300) Subject: Re: [PATCH: gdb/mi + doco] -var-update Reply-to: Eli Zaretskii References: <16919.7660.144228.334687@farnswood.snap.net.nz> <01c5167f$Blat.v2.4$9a7a6f60@zahav.net.il> <16919.53411.753668.336933@farnswood.snap.net.nz> <01c51709$Blat.v2.4$4a3292a0@zahav.net.il> <16921.18627.457594.938060@farnswood.snap.net.nz> X-SW-Source: 2005-02/txt/msg00220.txt.bz2 > From: Nick Roberts > Date: Mon, 21 Feb 2005 15:34:43 +1300 > Cc: gdb-patches@sources.redhat.com > > > If other messages are marked up with _(), then this is okay. But I > > still think the const char [] strings should be defined once and used > > elsewhere in this function. > > OK but this only makes sense if it is done consistently. So I offer to > do it for all of the MI error messages. It should be done for all messages, yes; but I'd like at least to have the new messages follow that principle. > > > I've used "--all-values" because, in the case of -var-list-children there > > > is a third possibility: "--simple-values" and, to me, it seems simpler to > > > have only three values for print_values (mi-cmds.h): > > > > > > enum print_values { > > > PRINT_NO_VALUES, > > > PRINT_ALL_VALUES, > > > PRINT_SIMPLE_VALUES > > > }; > > > > I see the reason, but I think it is not important enough to use > > "--all-values". Anyway, the switch text does not need to be similar > > to the enum name, even if you use PRINT_ALL_VALUES in the enum. > > OK. But again this only makes sense if I change -var-list-children too. What change did you have in mind?