Re: [PATCH: gdb/mi + doco] -var-update

[Nick Roberts <nickrob@snap.net.nz>]

Daniel Jacobowitz writes:
 > On Fri, Jun 17, 2005 at 11:42:52PM +1200, Nick Roberts wrote:
 > >  > You've replaced "--all-values" in the source with "--with-values" here. 
 > >  > Surely that's a bug?
 > 
 > You don't really seem to answer this.  -stack-list-locals today accepts
 > --all-values and does not accept --with-values.  It has for a year and
 > a half, so it was in a released version of GDB.  Why're you removing
 > that?

Eli asked me to use --with-values for -var-update.  Since, after the change,
-stack-list-locals would have the same options, I thought they should have
the same names. FWIW my preference is the same as yours: to use --all-values
throughout.

 > name = argv[1];
 > 
 > not:
 > 
 > name = (argv[1]);

OK

 > >  > IIRC, you added the "0"/"1" compatibility to -var-list-children to make
 > >  > life easier for Apple.  Is that right?  If so, do they need it here
 > >  > also, or can we get away with just --all-values?  I've no real
 > >  > objection to the 0/1, but they're a bit ugly.
 > > 
 > >  I think I originally copied the "0"/"1" arguments for -var-list-children
 > > from existing behaviour for -stack-list-locals.  I also think that Apple
 > > had already done something similar but different (looking through the e-mails
 > > their arguments had reverse the order: SHOW-VALUE VAROBJ-HANDLE).  If these
 > > are removed then I need to keep "-all-values" for -var-list-children for
 > > backward compatiblity (GDB 6.1 to 6.3?).

 > I don't see why the presence of the 0/1 make any difference to the
 > --with-values/--all-values question.  But if no one is already using
 > the 0/1 syntax, let's not introduce new uses of it; the existing uses
 > can stay, but we don't need more.

-var-list-children --all-values VARNUM      works with 6.3.

-var-list-children --with-values VARNUM     would work with 6.4 if these
                                            changes are installed.

-var-list-children 1 VARNUM                 would work with 6.3 and 6.4 if
                                            these changes are installed.


Nick