From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14993 invoked by alias); 2 May 2005 02:06:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14028 invoked from network); 2 May 2005 02:06:50 -0000 Received: from unknown (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org with SMTP; 2 May 2005 02:06:50 -0000 Received: from farnswood.snap.net.nz (p217-tnt2.snap.net.nz [202.124.108.217]) by viper.snap.net.nz (Postfix) with ESMTP id 6DD3D4B0698; Mon, 2 May 2005 14:06:48 +1200 (NZST) Received: by farnswood.snap.net.nz (Postfix, from userid 501) id AEDD762A99; Mon, 2 May 2005 03:06:57 +0100 (BST) From: Nick Roberts Message-ID: <17013.35649.62745.226730@farnswood.snap.net.nz> Date: Mon, 02 May 2005 02:06:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Bob Rossi Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH: gdb/mi + doco] -var-update In-Reply-To: <20050401024942.GA2179@white> References: <16919.7660.144228.334687@farnswood.snap.net.nz> <01c5167f$Blat.v2.4$9a7a6f60@zahav.net.il> <16919.53411.753668.336933@farnswood.snap.net.nz> <01c51709$Blat.v2.4$4a3292a0@zahav.net.il> <16921.18627.457594.938060@farnswood.snap.net.nz> <01c517d0$Blat.v2.4$09a26040@zahav.net.il> <16922.43915.346792.973282@farnswood.snap.net.nz> <01c51898$Blat.v2.4$f6fd05c0@zahav.net.il> <16929.8147.933720.246602@farnswood.snap.net.nz> <16955.41017.161288.832646@farnswood.snap.net.nz> <20050401024942.GA2179@white> X-SW-Source: 2005-05/txt/msg00036.txt.bz2 > I have some spare time waiting for my patches to get reviewed, so I > figure'd I'd look at yours. If you care, I have just a few comments. Sorry, Bob. I read this too quickly the first time and (stupidly) thought that you had forgot to include the comments. > > + const char novalues[] = "\"--no-values\""; > > + const char withvalues[] = "\"--with-values\""; > > + const char simplevalues[] = "\"--simple-values\""; > > + const char allvalues[] = "\"--all-values\""; > > These could be made static. Not really. I use them in my patch for mi-cmd-stack.c which I included in my earlier submission (Sun, 27 Feb 2005 14:18:11 +1300) but left out on (Mar 19) as it was unchanged. ... > > ! if (strcmp (argv[0], "0") == 0 > > ! || strcmp (argv[0], "--no-values") == 0) > > ! print_values = PRINT_NO_VALUES; > > ! else if (strcmp (argv[0], "1") == 0 > > ! || strcmp (argv[0], "--with-values") == 0) > > instead of using "--no-values" and "--with-values" you could use the > variable "novalues" and "withvalues". Yes. That would make sense. > > ! if (argc == 2) > > ! { > > ! if (strcmp (argv[0], "0") == 0 > > ! || strcmp (argv[0], "--no-values") == 0) > > ! print_values = PRINT_NO_VALUES; > > ! else if (strcmp (argv[0], "1") == 0 > > ! || strcmp (argv[0], "--with-values") == 0) > > same as above with the --no-values and --with-values Yes. I will send the revised source (all files apart from doco which Eli has already approved) to Daniel and cc gdb-patches. Nick