Re: Powerpc and software single step

[Jimi Xenidis <jimix@watson.ibm.com>]

>>>>> "KB" == Kevin Buettner <kevinb@redhat.com> writes:

 KB> On Aug 12,  6:31pm, Jimi Xenidis wrote:
 KB> The patch looks mostly okay to me.  I do have some comments and questions
 KB> though...

 KB> 1) It is customary to provide ChangeLog entries with patch
 KB>    submissions.
Hows this?

2003-08-19  Jimi Xenidis  <jimix@watson.ibm.com>

	* ppc-linux-tdep.c (ppc_linux_software_single_step): Allow for
	single step mode (SW or HW assisted) to be selectable.
	* config/powerpc/tm-linux.h (SOFTWARE_SINGLE_STEP): Likewise

 KB> 2) Why is ``ppc_linux_single_step_mode'' an extern in tm-linux.h?  I
 KB>    would really prefer that it be local to ppc-linux-tdep.c.  If
 KB>    there's some compelling reason for it to not be local, then we can
 KB>    discuss adding it to ppc-tdep.h.
Both macros (one for test and one for that call itself) are used all
over the gdb source so I do not see how iether one can be local

 KB> 3) Is a copyright assignment needed for this patch?

 KB>    [ This question is not just for Jimi, but for others reading this
 KB>    list as well.  I'm leaving Jimi's patch quoted below so that others
 KB>    can look without having to dig up the original patch submission.  ]

I submitted this patch in hopes that it would sneak under the
copyright radar. Let me know if it does not

-JX