Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step

[Kevin Buettner <kevinb@redhat.com>]

On Sep 9, 11:30am, Jimi Xenidis wrote:

> >>>>> "KB" == Kevin Buettner <kevinb@redhat.com> writes:
> 
>  KB> Would you mind doing some tracing to figure out why wrapping it
>  KB> with a test for AIX wasn't necessary?  The fact that you didn't
>  KB> need a test suggests that there's a bug somewhere else...
> 
> gdb/config/powerpc/tm-ppc-eabi.h defines the predicate
> SOFTWARE_SINGLE_STEP_P() as 0 but does not define
> SOFTWARE_SINGLE_STEP() at all. If I remove this def then all works as
> expected.
> 
> So what should the AIX test be? possible canidates are:
>   ? if (info.osabi != GDB_OSABI_LINUX)
>     * Not sure if this is good enough for the PPC-EABI or anyone else
>   ? if (from_xcoff_exec)
> 
> or clear it to NULL in ppclinux and eabi.
> 
> thoughts?

Ideally, we'd have a GDB_OSABI_AIX constant to use for the test.

It'd also be nice if (eventually) the generic vs AIX specific code
were split into two separate files.  At first, I was thinking that AIX
specific code ought to move to a different file, but now I think it makes
more sense to do it the other way around, i.e, move the generic PPC
(and Power) code to its own file and let rs6000-tdep.c contain only
AIX specific code in much the same way that ppc-linux-tdep.c contains
only linux specific code.

Kevin