From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21574 invoked by alias); 9 Sep 2003 16:15:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21566 invoked from network); 9 Sep 2003 16:15:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Sep 2003 16:15:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h89GFSl08621 for ; Tue, 9 Sep 2003 12:15:28 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h89GFQe14512; Tue, 9 Sep 2003 12:15:26 -0400 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h89GFOba008113; Tue, 9 Sep 2003 12:15:25 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h89GFJT20804; Tue, 9 Sep 2003 09:15:19 -0700 Date: Tue, 09 Sep 2003 16:15:00 -0000 From: Kevin Buettner Message-Id: <1030909161519.ZM20803@localhost.localdomain> In-Reply-To: Jimi Xenidis "AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step" (Sep 9, 11:30am) References: <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> <20030908190016.GB24747@nevyn.them.org> <16220.58287.637563.556990@kitch0.watson.ibm.com> <20030908202005.GA30286@nevyn.them.org> <16220.62220.290008.652878@kitch0.watson.ibm.com> <1030908220107.ZM6208@localhost.localdomain> <16221.61979.434255.784317@kitch0.watson.ibm.com> To: Jimi Xenidis , Kevin Buettner Subject: Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com, Andrew Cagney MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00160.txt.bz2 On Sep 9, 11:30am, Jimi Xenidis wrote: > >>>>> "KB" == Kevin Buettner writes: > > KB> Would you mind doing some tracing to figure out why wrapping it > KB> with a test for AIX wasn't necessary? The fact that you didn't > KB> need a test suggests that there's a bug somewhere else... > > gdb/config/powerpc/tm-ppc-eabi.h defines the predicate > SOFTWARE_SINGLE_STEP_P() as 0 but does not define > SOFTWARE_SINGLE_STEP() at all. If I remove this def then all works as > expected. > > So what should the AIX test be? possible canidates are: > ? if (info.osabi != GDB_OSABI_LINUX) > * Not sure if this is good enough for the PPC-EABI or anyone else > ? if (from_xcoff_exec) > > or clear it to NULL in ppclinux and eabi. > > thoughts? Ideally, we'd have a GDB_OSABI_AIX constant to use for the test. It'd also be nice if (eventually) the generic vs AIX specific code were split into two separate files. At first, I was thinking that AIX specific code ought to move to a different file, but now I think it makes more sense to do it the other way around, i.e, move the generic PPC (and Power) code to its own file and let rs6000-tdep.c contain only AIX specific code in much the same way that ppc-linux-tdep.c contains only linux specific code. Kevin