From: Jimi Xenidis <jimix@watson.ibm.com>
To: gdb-patches@sources.redhat.com
Cc: Andrew Cagney <ac131313@redhat.com>
Subject: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step
Date: Mon, 08 Sep 2003 18:58:00 -0000 [thread overview]
Message-ID: <16220.53590.956496.102996@kitch0.watson.ibm.com> (raw)
In-Reply-To: <3F465EFD.9020700@redhat.com>
>>>>> "AC" == Andrew Cagney <ac131313@redhat.com> writes:
AC> What about a patch to eliminate the macros? Good incremental step.
Your wish is my (very much delayed) command ;-)
Changelog:
2003-09-08 Jimi Xenidis <jimix@watson.ibm.com>
* config/rs6000/tm-rs6000.h: no longer require custion #define of
SOFTWARE_SINGLE_STEP
* config/powerpc/tm-linux.h: no longer require custion #define of
SOFTWARE_SINGLE_STEP
* rs6000-tdep.c (rs6000_gdbarch_init): Set up software_single_step
while initing gdbarch
Patch:
Index: gdb/rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.148
diff -u -u -r1.148 rs6000-tdep.c
--- gdb/rs6000-tdep.c 18 Aug 2003 20:04:55 -0000 1.148
+++ gdb/rs6000-tdep.c 8 Sep 2003 17:51:53 -0000
@@ -3015,6 +3015,9 @@
/* Hook in ABI-specific overrides, if they have been registered. */
gdbarch_init_osabi (info, gdbarch);
+ /* RS6000/AIX does not support PT_STEP. Has to be simulated. */
+ set_gdbarch_software_single_step (gdbarch, rs6000_software_single_step);
+
return gdbarch;
}
Index: gdb/config/powerpc/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v
retrieving revision 1.14
diff -u -u -r1.14 tm-linux.h
--- gdb/config/powerpc/tm-linux.h 3 Sep 2003 21:01:44 -0000 1.14
+++ gdb/config/powerpc/tm-linux.h 8 Sep 2003 17:51:53 -0000
@@ -31,12 +31,6 @@
#undef IN_SOLIB_CALL_TRAMPOLINE
#undef SKIP_TRAMPOLINE_CODE
-/* We can single step on linux */
-#undef SOFTWARE_SINGLE_STEP
-#define SOFTWARE_SINGLE_STEP(p,q) internal_error (__FILE__, __LINE__, "Will never execute!")
-#undef SOFTWARE_SINGLE_STEP_P
-#define SOFTWARE_SINGLE_STEP_P() 0
-
/* Make sure nexti gets the help it needs for debugging assembly code
without symbols */
Index: gdb/config/rs6000/tm-rs6000.h
===================================================================
RCS file: /cvs/src/src/gdb/config/rs6000/tm-rs6000.h,v
retrieving revision 1.26
diff -u -u -r1.26 tm-rs6000.h
--- gdb/config/rs6000/tm-rs6000.h 3 Sep 2003 21:01:44 -0000 1.26
+++ gdb/config/rs6000/tm-rs6000.h 8 Sep 2003 17:51:53 -0000
@@ -90,12 +90,6 @@
extern CORE_ADDR init_frame_pc_noop (int fromleaf, struct frame_info *prev);
#define DEPRECATED_INIT_FRAME_PC(fromleaf, prev) (init_frame_pc_noop (fromleaf, prev))
-/* RS6000/AIX does not support PT_STEP. Has to be simulated. */
-
-#define SOFTWARE_SINGLE_STEP_P() 1
-extern void rs6000_software_single_step (enum target_signal, int);
-#define SOFTWARE_SINGLE_STEP(sig,bp_p) rs6000_software_single_step (sig, bp_p)
-
/* Notice when a new child process is started. */
#define TARGET_CREATE_INFERIOR_HOOK rs6000_create_inferior
next prev parent reply other threads:[~2003-09-08 18:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 22:31 Jimi Xenidis
2003-08-19 17:55 ` Kevin Buettner
2003-08-19 19:05 ` Jimi Xenidis
2003-08-19 19:13 ` Daniel Jacobowitz
2003-08-19 22:32 ` Jimi Xenidis
2003-08-20 2:30 ` Daniel Jacobowitz
2003-08-20 2:57 ` Jimi Xenidis
2003-08-20 3:09 ` Daniel Jacobowitz
2003-08-20 3:21 ` Jimi Xenidis
2003-08-20 13:07 ` Daniel Jacobowitz
2003-08-20 13:54 ` Jimi Xenidis
2003-08-20 15:51 ` Andrew Cagney
2003-08-20 16:02 ` Jimi Xenidis
2003-08-21 3:48 ` Andrew Cagney
2003-08-22 13:17 ` Jimi Xenidis
2003-08-22 15:54 ` Andrew Cagney
2003-08-22 17:32 ` Jimi Xenidis
2003-08-22 18:20 ` Andrew Cagney
2003-09-08 18:58 ` Jimi Xenidis [this message]
2003-09-08 19:00 ` Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: " Daniel Jacobowitz
2003-09-08 20:17 ` Jimi Xenidis
2003-09-08 20:20 ` Daniel Jacobowitz
2003-09-08 21:22 ` Jimi Xenidis
2003-09-08 22:01 ` Kevin Buettner
2003-09-09 10:30 ` Jimi Xenidis
2003-09-09 15:30 ` AHAH! " Jimi Xenidis
2003-09-09 16:15 ` Kevin Buettner
2003-09-09 17:01 ` Jimi Xenidis
2003-09-09 17:55 ` Kevin Buettner
2003-09-09 22:01 ` PATCH: Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP Jimi Xenidis
2003-09-10 1:24 ` Kevin Buettner
2003-10-10 2:40 ` Andrew Cagney
2003-08-20 2:30 ` Powerpc and software single step Andrew Cagney
2003-08-20 2:33 ` Daniel Jacobowitz
2003-08-21 14:01 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16220.53590.956496.102996@kitch0.watson.ibm.com \
--to=jimix@watson.ibm.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox