From: Kevin Buettner <kevinb@redhat.com>
To: Jimi Xenidis <jimix@watson.ibm.com>, Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, Andrew Cagney <ac131313@redhat.com>
Subject: Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step
Date: Mon, 08 Sep 2003 22:01:00 -0000 [thread overview]
Message-ID: <1030908220107.ZM6208@localhost.localdomain> (raw)
In-Reply-To: Jimi Xenidis <jimix@watson.ibm.com> "Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step" (Sep 8, 5:22pm)
On Sep 8, 5:22pm, Jimi Xenidis wrote:
> >>>>> "DJ" == Daniel Jacobowitz <drow@mvista.com> writes:
> DJ> Are you sure you posted the patch you tested?
>
> yes and it was tested on aix.
>
> DJ> You added a call to set_gdbarch_software_single_step to
> DJ> rs6000_gdbarch_init. It wasn't conditional on anything relating to
> DJ> AIX. By all rights that _should_ set gdbarch_software_singlestep_p for
> DJ> GNU/Linux.
>
> I agree with you and am equally puzzled, but it does not, I expected
> to wrap it in:
> if (info->osabi != GDB_OSABI_LINUX)
> but it was not necessary.
> Actually wanted == GDB_OSABI_AIX but there was no such animal.
>
> thoughts?
Would you mind doing some tracing to figure out why wrapping it
with a test for AIX wasn't necessary? The fact that you didn't
need a test suggests that there's a bug somewhere else...
Kevin
next prev parent reply other threads:[~2003-09-08 22:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 22:31 Jimi Xenidis
2003-08-19 17:55 ` Kevin Buettner
2003-08-19 19:05 ` Jimi Xenidis
2003-08-19 19:13 ` Daniel Jacobowitz
2003-08-19 22:32 ` Jimi Xenidis
2003-08-20 2:30 ` Daniel Jacobowitz
2003-08-20 2:57 ` Jimi Xenidis
2003-08-20 3:09 ` Daniel Jacobowitz
2003-08-20 3:21 ` Jimi Xenidis
2003-08-20 13:07 ` Daniel Jacobowitz
2003-08-20 13:54 ` Jimi Xenidis
2003-08-20 15:51 ` Andrew Cagney
2003-08-20 16:02 ` Jimi Xenidis
2003-08-21 3:48 ` Andrew Cagney
2003-08-22 13:17 ` Jimi Xenidis
2003-08-22 15:54 ` Andrew Cagney
2003-08-22 17:32 ` Jimi Xenidis
2003-08-22 18:20 ` Andrew Cagney
2003-09-08 18:58 ` Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: " Jimi Xenidis
2003-09-08 19:00 ` Daniel Jacobowitz
2003-09-08 20:17 ` Jimi Xenidis
2003-09-08 20:20 ` Daniel Jacobowitz
2003-09-08 21:22 ` Jimi Xenidis
2003-09-08 22:01 ` Kevin Buettner [this message]
2003-09-09 10:30 ` Jimi Xenidis
2003-09-09 15:30 ` AHAH! " Jimi Xenidis
2003-09-09 16:15 ` Kevin Buettner
2003-09-09 17:01 ` Jimi Xenidis
2003-09-09 17:55 ` Kevin Buettner
2003-09-09 22:01 ` PATCH: Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP Jimi Xenidis
2003-09-10 1:24 ` Kevin Buettner
2003-10-10 2:40 ` Andrew Cagney
2003-08-20 2:30 ` Powerpc and software single step Andrew Cagney
2003-08-20 2:33 ` Daniel Jacobowitz
2003-08-21 14:01 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030908220107.ZM6208@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimix@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox