From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25360 invoked by alias); 8 Sep 2003 22:01:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25333 invoked from network); 8 Sep 2003 22:01:17 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 Sep 2003 22:01:17 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h88M1Gl23964 for ; Mon, 8 Sep 2003 18:01:16 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h88M1Ee19243; Mon, 8 Sep 2003 18:01:14 -0400 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h88M1DXS015733; Mon, 8 Sep 2003 18:01:13 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h88M17w06209; Mon, 8 Sep 2003 15:01:07 -0700 Date: Mon, 08 Sep 2003 22:01:00 -0000 From: Kevin Buettner Message-Id: <1030908220107.ZM6208@localhost.localdomain> In-Reply-To: Jimi Xenidis "Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step" (Sep 8, 5:22pm) References: <3F4398EC.2050405@redhat.com> <16195.39851.78762.619597@kitch0.watson.ibm.com> <3F4440F0.30007@redhat.com> <16198.6133.411978.563514@kitch0.watson.ibm.com> <3F463CA9.5000900@redhat.com> <16198.21410.308896.588372@kitch0.watson.ibm.com> <3F465EFD.9020700@redhat.com> <16220.53590.956496.102996@kitch0.watson.ibm.com> <20030908190016.GB24747@nevyn.them.org> <16220.58287.637563.556990@kitch0.watson.ibm.com> <20030908202005.GA30286@nevyn.them.org> <16220.62220.290008.652878@kitch0.watson.ibm.com> To: Jimi Xenidis , Daniel Jacobowitz Subject: Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step Cc: gdb-patches@sources.redhat.com, Andrew Cagney MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00137.txt.bz2 On Sep 8, 5:22pm, Jimi Xenidis wrote: > >>>>> "DJ" == Daniel Jacobowitz writes: > DJ> Are you sure you posted the patch you tested? > > yes and it was tested on aix. > > DJ> You added a call to set_gdbarch_software_single_step to > DJ> rs6000_gdbarch_init. It wasn't conditional on anything relating to > DJ> AIX. By all rights that _should_ set gdbarch_software_singlestep_p for > DJ> GNU/Linux. > > I agree with you and am equally puzzled, but it does not, I expected > to wrap it in: > if (info->osabi != GDB_OSABI_LINUX) > but it was not necessary. > Actually wanted == GDB_OSABI_AIX but there was no such animal. > > thoughts? Would you mind doing some tracing to figure out why wrapping it with a test for AIX wasn't necessary? The fact that you didn't need a test suggests that there's a bug somewhere else... Kevin