From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1290 invoked by alias); 19 Aug 2003 19:05:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1283 invoked from network); 19 Aug 2003 19:05:58 -0000 Received: from unknown (HELO igw2.watson.ibm.com) (129.34.20.6) by sources.redhat.com with SMTP; 19 Aug 2003 19:05:58 -0000 Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com [9.2.112.57]) by igw2.watson.ibm.com (8.11.7/8.11.4) with ESMTP id h7JJ3Zj72808; Tue, 19 Aug 2003 15:03:35 -0400 Received: from kitch0.watson.ibm.com (kitch0.watson.ibm.com [9.2.224.107]) by sp1n293en1.watson.ibm.com (8.11.7/8.11.7) with ESMTP id h7JJ5q141412; Tue, 19 Aug 2003 15:05:52 -0400 Received: (from jimix@localhost) by kitch0.watson.ibm.com (AIX4.3/8.9.3p2/8.9.3/09-18-2002) id PAA68336; Tue, 19 Aug 2003 15:05:52 -0400 From: Jimi Xenidis MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16194.29967.770787.796782@kitch0.watson.ibm.com> Date: Tue, 19 Aug 2003 19:05:00 -0000 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, Andrew Cagney Subject: Re: Powerpc and software single step In-Reply-To: <1030819175512.ZM31220@localhost.localdomain> References: <16185.27333.689024.383508@kitch0.watson.ibm.com> <1030819175512.ZM31220@localhost.localdomain> X-SW-Source: 2003-08/txt/msg00321.txt.bz2 >>>>> "KB" == Kevin Buettner writes: KB> On Aug 12, 6:31pm, Jimi Xenidis wrote: KB> The patch looks mostly okay to me. I do have some comments and questions KB> though... KB> 1) It is customary to provide ChangeLog entries with patch KB> submissions. Hows this? 2003-08-19 Jimi Xenidis * ppc-linux-tdep.c (ppc_linux_software_single_step): Allow for single step mode (SW or HW assisted) to be selectable. * config/powerpc/tm-linux.h (SOFTWARE_SINGLE_STEP): Likewise KB> 2) Why is ``ppc_linux_single_step_mode'' an extern in tm-linux.h? I KB> would really prefer that it be local to ppc-linux-tdep.c. If KB> there's some compelling reason for it to not be local, then we can KB> discuss adding it to ppc-tdep.h. Both macros (one for test and one for that call itself) are used all over the gdb source so I do not see how iether one can be local KB> 3) Is a copyright assignment needed for this patch? KB> [ This question is not just for Jimi, but for others reading this KB> list as well. I'm leaving Jimi's patch quoted below so that others KB> can look without having to dig up the original patch submission. ] I submitted this patch in hopes that it would sneak under the copyright radar. Let me know if it does not -JX